diff options
| author | Christian Kandeler <christian.kandeler@qt.io> | 2023-06-22 14:58:11 +0200 |
|---|---|---|
| committer | Christian Kandeler <christian.kandeler@qt.io> | 2023-06-23 09:51:54 +0000 |
| commit | cf6bd7e0124f31374f3a4abd05d14199d201961b (patch) | |
| tree | 90ce2081bdea0b7bece256bd00c0d0476171e00f /src/plugins/fakevim | |
| parent | ae33199d046902bb9877810df2dbc590b083ef3c (diff) | |
Fix occurrences of the contains/insert anti-pattern
Introduce and make use of Utils::insert() for QSet with a return value
that indicates whether insertion actually happened.
Change-Id: I655e4bc3553b74fea5ae8956205e4d8070118d63
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/fakevim')
| -rw-r--r-- | src/plugins/fakevim/fakevimplugin.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/fakevim/fakevimplugin.cpp b/src/plugins/fakevim/fakevimplugin.cpp index 54ae4ca93f..5b51cb5f96 100644 --- a/src/plugins/fakevim/fakevimplugin.cpp +++ b/src/plugins/fakevim/fakevimplugin.cpp @@ -45,6 +45,7 @@ #include <texteditor/textmark.h> #include <texteditor/typingsettings.h> +#include <utils/algorithm.h> #include <utils/aspects.h> #include <utils/fancylineedit.h> #include <utils/hostosinfo.h> @@ -944,9 +945,8 @@ public: QString found = sel.selectedText(); // Only add "real" completions. if (found.startsWith(needle) - && !seen.contains(found) - && sel.anchor() != basePosition) { - seen.insert(found); + && sel.anchor() != basePosition + && Utils::insert(seen, found)) { auto item = new FakeVimAssistProposalItem(m_provider); item->setText(found); items.append(item); |