Add FSEngine FilePath Cache

To speed up file dialogs we introduce a 1 minute cache for
the FilePathInfo.

A new version of "IDevice::iterateDirectories" allows implementations to
provide the FilePathInfo directly.

DockerDevice implements fetching the filePathInfo during
iterateDirectories which greatly improves the speed again.

Change-Id: I24ac16adb2478cbf16a22012e72fcb8910dcdac5
Reviewed-by: hjk <hjk@qt.io>

1 files changed, 16 insertions, 2 deletions

diff --git a/src/plugins/projectexplorer/devicesupport/devicemanager.cpp b/src/plugins/projectexplorer/devicesupport/devicemanager.cpp
index febcc6436e..c5a7f4e810 100644
--- a/src/plugins/projectexplorer/devicesupport/devicemanager.cpp
+++ b/src/plugins/projectexplorer/devicesupport/devicemanager.cpp
@@ -521,10 +521,18 @@ DeviceManager::DeviceManager(bool isInstance) : d(std::make_unique<DeviceManager
     };
 
     deviceHooks.iterateDirectory = [](const FilePath &filePath,
-                                      const std::function<bool(const FilePath &)> &callBack,
+                                      const FilePath::IterateDirCallback &callBack,
                                       const FileFilter &filter) {
         auto device = DeviceManager::deviceForPath(filePath);
-        QTC_ASSERT(device, return);
+        QTC_ASSERT(device, return );
+        device->iterateDirectory(filePath, callBack, filter);
+    };
+
+    deviceHooks.iterateDirectoryWithInfo = [](const FilePath &filePath,
+                                              const FilePath::IterateDirWithInfoCallback &callBack,
+                                              const FileFilter &filter) {
+        auto device = DeviceManager::deviceForPath(filePath);
+        QTC_ASSERT(device, return );
         device->iterateDirectory(filePath, callBack, filter);
     };
 
@@ -552,6 +560,12 @@ DeviceManager::DeviceManager(bool isInstance) : d(std::make_unique<DeviceManager
         return device->writeFileContents(filePath, data, offset);
     };
 
+    deviceHooks.filePathInfo = [](const FilePath &filePath) -> FilePathInfo {
+        auto device = DeviceManager::deviceForPath(filePath);
+        QTC_ASSERT(device, return {});
+        return device->filePathInfo(filePath);
+    };
+
     deviceHooks.lastModified = [](const FilePath &filePath) {
         auto device = DeviceManager::deviceForPath(filePath);
         QTC_ASSERT(device, return QDateTime());