diff options
author | hjk <hjk@qt.io> | 2018-05-04 15:13:41 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2018-05-08 12:57:03 +0000 |
commit | 4ca54d86ff5940b1f3968ed581c6170b20eac321 (patch) | |
tree | 6ad7687a92ccd9463207f26dac42969361cfda5d /src/plugins/projectexplorer/runconfigurationaspects.h | |
parent | 736f7f89d1a90227a6fada5cb1d7143e4d6d2431 (diff) |
Enhance IRunConfigurationAspect base interface
Move some commonly used functions to the base,
The plan is to identify aspects by Id instead of type more often,
so avoid casts proactively.
Change-Id: I1b94b858a4491a0e31cedc788ded643a82242b2a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/projectexplorer/runconfigurationaspects.h')
-rw-r--r-- | src/plugins/projectexplorer/runconfigurationaspects.h | 24 |
1 files changed, 6 insertions, 18 deletions
diff --git a/src/plugins/projectexplorer/runconfigurationaspects.h b/src/plugins/projectexplorer/runconfigurationaspects.h index 3ece63d1cb..8a393e4063 100644 --- a/src/plugins/projectexplorer/runconfigurationaspects.h +++ b/src/plugins/projectexplorer/runconfigurationaspects.h @@ -50,7 +50,7 @@ public: TerminalAspect(RunConfiguration *rc, const QString &settingsKey, bool useTerminal = false); - void addToConfigurationLayout(QFormLayout *layout); + void addToConfigurationLayout(QFormLayout *layout) override; bool useTerminal() const; void setUseTerminal(bool useTerminal); @@ -60,9 +60,6 @@ public: bool isUserSet() const; -signals: - void useTerminalChanged(bool); - private: void fromMap(const QVariantMap &map) override; void toMap(QVariantMap &map) const override; @@ -80,7 +77,7 @@ public: explicit WorkingDirectoryAspect(RunConfiguration *runConfig, const QString &settingsKey = QString()); - void addToConfigurationLayout(QFormLayout *layout); + void addToConfigurationLayout(QFormLayout *layout) override; Utils::FileName workingDirectory() const; Utils::FileName defaultWorkingDirectory() const; @@ -108,7 +105,7 @@ class PROJECTEXPLORER_EXPORT ArgumentsAspect : public IRunConfigurationAspect public: explicit ArgumentsAspect(RunConfiguration *runConfig, const QString &settingsKey = QString()); - void addToConfigurationLayout(QFormLayout *layout); + void addToConfigurationLayout(QFormLayout *layout) override; QString arguments() const; QString unexpandedArguments() const; @@ -134,7 +131,7 @@ public: explicit BaseBoolAspect(RunConfiguration *rc, const QString &settingsKey = QString()); ~BaseBoolAspect() override; - void addToConfigurationLayout(QFormLayout *layout); + void addToConfigurationLayout(QFormLayout *layout) override; bool value() const; void setValue(bool val); @@ -144,9 +141,6 @@ public: void fromMap(const QVariantMap &map) override; void toMap(QVariantMap &map) const override; -signals: - void changed(); - private: bool m_value = false; QString m_label; @@ -177,7 +171,7 @@ public: explicit BaseStringAspect(RunConfiguration *rc); ~BaseStringAspect() override; - void addToConfigurationLayout(QFormLayout *layout); + void addToConfigurationLayout(QFormLayout *layout) override; QString value() const; void setValue(const QString &val); @@ -203,9 +197,6 @@ public: Utils::FileName fileName() const; void setFileName(const Utils::FileName &val); -signals: - void changed(); - private: void update(); @@ -238,7 +229,7 @@ public: void setSettingsKey(const QString &key); void makeOverridable(const QString &overridingKey, const QString &useOverridableKey); - void addToConfigurationLayout(QFormLayout *layout); + void addToConfigurationLayout(QFormLayout *layout) override; void setLabelText(const QString &labelText); void setPlaceHolderText(const QString &placeHolderText); void setExecutablePathStyle(Utils::OsType osType); @@ -247,9 +238,6 @@ public: void setEnvironment(const Utils::Environment &env); void setDisplayStyle(BaseStringAspect::DisplayStyle style); -signals: - void changed(); - protected: void fromMap(const QVariantMap &map) override; void toMap(QVariantMap &map) const override; |