Unify key names for various fields in stored RunConfigurations

This replaces various versions of the key name of the arguments,
working directory, use terminal and use dyld image suffix fields
by unified versions ("RunConfiguration.Arguments",
"RunConfiguration.WorkingDirectory", "RunConfiguration.UseTerminal",
"RunConfiguration.UseDyldImageSuffix").

The different names for the fields are technically not needed
(as proven by several cases that already now used the same key),
partially outdated ("Qt4ProjectManager.MaemoRunConfiguration.Arguments")
make RunConfiguration constructors less uniform and more complex
than needed.

The "RunConfiguration." prefix in the new names is not needed, but used
by several other settings, so having it there looks more uniform now.

In (the unexpected case) that different keys would ever be necessary,
the default key name could still be overridden by using setSettingsKey
from user code.

Change-Id: Ifb74ad74e0a9c724c8bf5e71e1bb2424d5d1831b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

1 files changed, 5 insertions, 7 deletions

diff --git a/src/plugins/projectexplorer/runconfigurationaspects.h b/src/plugins/projectexplorer/runconfigurationaspects.h
index 26d56b4080..34c96158bb 100644
--- a/src/plugins/projectexplorer/runconfigurationaspects.h
+++ b/src/plugins/projectexplorer/runconfigurationaspects.h
@@ -47,8 +47,7 @@ class PROJECTEXPLORER_EXPORT TerminalAspect : public IRunConfigurationAspect
     Q_OBJECT
 
 public:
-    TerminalAspect(RunConfiguration *rc, const QString &settingsKey,
-                   bool useTerminal = false);
+    TerminalAspect(RunConfiguration *rc, bool useTerminal = false);
 
     void addToConfigurationLayout(QFormLayout *layout) override;
 
@@ -71,8 +70,7 @@ class PROJECTEXPLORER_EXPORT WorkingDirectoryAspect : public IRunConfigurationAs
     Q_OBJECT
 
 public:
-    explicit WorkingDirectoryAspect(RunConfiguration *runConfig,
-                                    const QString &settingsKey = QString());
+    explicit WorkingDirectoryAspect(RunConfiguration *runConfig);
 
     void addToConfigurationLayout(QFormLayout *layout) override;
 
@@ -100,7 +98,7 @@ class PROJECTEXPLORER_EXPORT ArgumentsAspect : public IRunConfigurationAspect
     Q_OBJECT
 
 public:
-    explicit ArgumentsAspect(RunConfiguration *runConfig, const QString &settingsKey = QString());
+    explicit ArgumentsAspect(RunConfiguration *runConfig);
 
     void addToConfigurationLayout(QFormLayout *layout) override;
 
@@ -149,7 +147,7 @@ class PROJECTEXPLORER_EXPORT UseLibraryPathsAspect : public BaseBoolAspect
     Q_OBJECT
 
 public:
-    UseLibraryPathsAspect(RunConfiguration *rc, const QString &settingsKey);
+    explicit UseLibraryPathsAspect(RunConfiguration *rc);
 };
 
 class PROJECTEXPLORER_EXPORT UseDyldSuffixAspect : public BaseBoolAspect
@@ -157,7 +155,7 @@ class PROJECTEXPLORER_EXPORT UseDyldSuffixAspect : public BaseBoolAspect
     Q_OBJECT
 
 public:
-    UseDyldSuffixAspect(RunConfiguration *rc, const QString &settingsKey);
+    explicit UseDyldSuffixAspect(RunConfiguration *rc);
 };
 
 class PROJECTEXPLORER_EXPORT BaseStringAspect : public IRunConfigurationAspect