diff options
author | hjk <hjk@qt.io> | 2020-09-14 12:37:32 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2020-10-05 08:16:51 +0000 |
commit | b97b7dc6f2aa2499575c53190a5f7210ddbedb3b (patch) | |
tree | 251564fd34649e673b0c5a0bc6a01ecd9cd55798 /src/plugins/qbsprojectmanager/qbsinstallstep.cpp | |
parent | ad7dbc46191e7a3d7308041fee426d35005a2a5f (diff) |
ProjectExplorer: Move BuildStepWidget::summary etc to BuildStep
The step is the source of information anyway, and available at the
only place of use. No need to copy that over to the widget, neither
for keeping it up-to-date there when the mechanism is already
available in the step itself.
This creates quite some potential for the simplification of
the various createConfigWidget implementations in follow-up patches.
Change-Id: I4474665f194a1ff7c5792ad086ed53c8d3ce13e6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/qbsprojectmanager/qbsinstallstep.cpp')
-rw-r--r-- | src/plugins/qbsprojectmanager/qbsinstallstep.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/plugins/qbsprojectmanager/qbsinstallstep.cpp b/src/plugins/qbsprojectmanager/qbsinstallstep.cpp index 661354ad29..925b6edea4 100644 --- a/src/plugins/qbsprojectmanager/qbsinstallstep.cpp +++ b/src/plugins/qbsprojectmanager/qbsinstallstep.cpp @@ -67,6 +67,7 @@ QbsInstallStep::QbsInstallStep(BuildStepList *bsl, Utils::Id id) : BuildStep(bsl, id) { setDisplayName(tr("Qbs Install")); + setSummaryText(tr("<b>Qbs:</b> %1").arg("install")); const auto labelPlacement = BoolAspect::LabelPlacement::AtCheckBoxWithoutDummyLabel; m_dryRun = addAspect<BoolAspect>(); @@ -182,8 +183,6 @@ BuildStepConfigWidget *QbsInstallStep::createConfigWidget() { auto widget = new BuildStepConfigWidget(this); - widget->setSummaryText(tr("<b>Qbs:</b> %1").arg("install")); - auto installRootValueLabel = new QLabel(installRoot()); auto commandLineKeyLabel = new QLabel(tr("Equivalent command line:")); |