aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/remotelinux/linuxdevice.h
diff options
context:
space:
mode:
authorChristian Kandeler <christian.kandeler@digia.com>2013-06-27 17:12:08 +0200
committerChristian Kandeler <christian.kandeler@digia.com>2013-07-02 15:02:48 +0200
commit5bca241afb51e89688b88e0dfb6580a5cf23372e (patch)
tree662b933af89d2fe4c76eb1b470239274e7264b88 /src/plugins/remotelinux/linuxdevice.h
parentd6062643c3994059233fc5e3b082932842c20a81 (diff)
Device support: Make device testing a "well-known" concept.
This entails the following: - Rename AbstractLinuxDeviceTester to DeviceTester and move it up into ProjectExplorer. The class stays unchanged, as there was nothing Linux-specific about it. The same goes for the associated dialog. - Move the createDeviceTester() function from LinuxDevice to IDevice and introduce IDevice::hasDeviceTester() to enable generic code to make use of this feature. - Move device testing out of the list of opaque device-specific actions; instead, the device settings widget now uses the device tester directly, if applicable. Rationale: - Device testing, just like remote process listing (if not more so), is a general concept that implementors of device classes will probably want to implement (and they should be encouraged to do so). Without the mechanism provided here, they would all need to put basically the same code into the actionIds(), displayNameForActionId() and executeAction() functions. This patch is the natural extension of b90e3bbd8bea27ad915a4d9033e0d5bda26f5667. Change-Id: I94f2badb4ceeda9f5cd3b066c13626bb4f65505d Reviewed-by: hjk <hjk121@nokiamail.com> Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Diffstat (limited to 'src/plugins/remotelinux/linuxdevice.h')
-rw-r--r--src/plugins/remotelinux/linuxdevice.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/remotelinux/linuxdevice.h b/src/plugins/remotelinux/linuxdevice.h
index 0ec84cd44e..7e8224a475 100644
--- a/src/plugins/remotelinux/linuxdevice.h
+++ b/src/plugins/remotelinux/linuxdevice.h
@@ -41,7 +41,6 @@ namespace Utils { class PortList; }
namespace RemoteLinux {
namespace Internal { class LinuxDevicePrivate; }
-class AbstractLinuxDeviceTester;
class REMOTELINUX_EXPORT LinuxDeviceProcessSupport : public ProjectExplorer::DeviceProcessSupport
{
@@ -74,7 +73,8 @@ public:
ProjectExplorer::PortsGatheringMethod::Ptr portsGatheringMethod() const;
bool canCreateProcessModel() const { return true; }
ProjectExplorer::DeviceProcessList *createProcessListModel(QObject *parent) const;
- virtual AbstractLinuxDeviceTester *createDeviceTester() const;
+ bool hasDeviceTester() const { return true; }
+ ProjectExplorer::DeviceTester *createDeviceTester() const;
protected:
LinuxDevice() {}