Vcs: Rename VcsBasePluginPrivate to VersionControlBase

The classes derived from this had a dual role of implementing the
version control interface (IVersionControl) and as the plugin pimpls.
The name was focusing on the latter, but plugin pimpls are being phased
out in the new 'setupFoo()' world, so only the version control interface
part remains.

Change-Id: I60396f1729c736bc6c9e4fca250a5926e9d60f51
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

7 files changed, 34 insertions, 34 deletions

diff --git a/src/plugins/vcsbase/basevcssubmiteditorfactory.cpp b/src/plugins/vcsbase/basevcssubmiteditorfactory.cpp
index af46903b38..55aef0b9d1 100644
--- a/src/plugins/vcsbase/basevcssubmiteditorfactory.cpp
+++ b/src/plugins/vcsbase/basevcssubmiteditorfactory.cpp
@@ -20,7 +20,7 @@ const char DIFF_SELECTED[] = "Vcs.DiffSelectedFiles";
 VcsSubmitEditorFactory::VcsSubmitEditorFactory
         (const VcsBaseSubmitEditorParameters &parameters,
          const EditorCreator &editorCreator,
-         VcsBasePluginPrivate *plugin)
+         VersionControlBase *plugin)
 {
     setId(parameters.id);
     setDisplayName(QLatin1String(parameters.displayName));
@@ -46,7 +46,7 @@ VcsSubmitEditorFactory::VcsSubmitEditorFactory
 
     Command *command = ActionManager::registerAction(&m_submitAction, SUBMIT, context);
     command->setAttribute(Command::CA_UpdateText);
-    QObject::connect(&m_submitAction, &QAction::triggered, plugin, &VcsBasePluginPrivate::commitFromEditor);
+    QObject::connect(&m_submitAction, &QAction::triggered, plugin, &VersionControlBase::commitFromEditor);
 
     m_diffAction.setIcon(VcsBaseSubmitEditor::diffIcon());
     m_diffAction.setText(Tr::tr("Diff &Selected Files"));
diff --git a/src/plugins/vcsbase/basevcssubmiteditorfactory.h b/src/plugins/vcsbase/basevcssubmiteditorfactory.h
index a7e30bb5a9..5aaa0fa727 100644
--- a/src/plugins/vcsbase/basevcssubmiteditorfactory.h
+++ b/src/plugins/vcsbase/basevcssubmiteditorfactory.h
@@ -14,7 +14,7 @@ namespace VcsBase {
 
 class VcsBaseSubmitEditor;
 class VcsBaseSubmitEditorParameters;
-class VcsBasePluginPrivate;
+class VersionControlBase;
 
 // Parametrizable base class for editor factories creating instances of
 // VcsBaseSubmitEditor subclasses.
@@ -26,7 +26,7 @@ public:
 
     VcsSubmitEditorFactory(const VcsBaseSubmitEditorParameters &parameters,
                            const EditorCreator &editorCreator,
-                           VcsBasePluginPrivate *plugin);
+                           VersionControlBase *plugin);
 
     ~VcsSubmitEditorFactory();
 
diff --git a/src/plugins/vcsbase/vcsbaseplugin.cpp b/src/plugins/vcsbase/vcsbaseplugin.cpp
index 95dad8bd6b..ee2ea42813 100644
--- a/src/plugins/vcsbase/vcsbaseplugin.cpp
+++ b/src/plugins/vcsbase/vcsbaseplugin.cpp
@@ -490,14 +490,14 @@ VCSBASE_EXPORT QDebug operator<<(QDebug in, const VcsBasePluginState &state)
     keep it, as it may rapidly change due to context changes, etc.
 */
 
-bool VcsBasePluginPrivate::supportsRepositoryCreation() const
+bool VersionControlBase::supportsRepositoryCreation() const
 {
     return supportsOperation(IVersionControl::CreateRepositoryOperation);
 }
 
 static Internal::StateListener *m_listener = nullptr;
 
-VcsBasePluginPrivate::VcsBasePluginPrivate(const Context &context)
+VersionControlBase::VersionControlBase(const Context &context)
     : m_context(context)
 {
     EditorManager::addCloseEditorListener([this](IEditor *editor) {
@@ -514,7 +514,7 @@ VcsBasePluginPrivate::VcsBasePluginPrivate(const Context &context)
     if (!m_listener)
         m_listener = new Internal::StateListener(Internal::VcsPlugin::instance());
     connect(m_listener, &Internal::StateListener::stateChanged,
-            this, &VcsBasePluginPrivate::slotStateChanged);
+            this, &VersionControlBase::slotStateChanged);
     // VCSes might have become (un-)available, so clear the VCS directory cache
     connect(this, &IVersionControl::configurationChanged,
             VcsManager::instance(), &VcsManager::clearVersionControlCache);
@@ -522,13 +522,13 @@ VcsBasePluginPrivate::VcsBasePluginPrivate(const Context &context)
             m_listener, &Internal::StateListener::slotStateChanged);
 }
 
-void VcsBasePluginPrivate::extensionsInitialized()
+void VersionControlBase::extensionsInitialized()
 {
     // Initialize enable menus.
     m_listener->slotStateChanged();
 }
 
-void VcsBasePluginPrivate::slotStateChanged(const Internal::State &newInternalState, IVersionControl *vc)
+void VersionControlBase::slotStateChanged(const Internal::State &newInternalState, IVersionControl *vc)
 {
     if (vc == this) {
         // We are directly affected: Change state
@@ -550,12 +550,12 @@ void VcsBasePluginPrivate::slotStateChanged(const Internal::State &newInternalSt
     }
 }
 
-const VcsBasePluginState &VcsBasePluginPrivate::currentState() const
+const VcsBasePluginState &VersionControlBase::currentState() const
 {
     return m_state;
 }
 
-VcsCommand *VcsBasePluginPrivate::createInitialCheckoutCommand(const QString &url,
+VcsCommand *VersionControlBase::createInitialCheckoutCommand(const QString &url,
                                                                const FilePath &baseDirectory,
                                                                const QString &localName,
                                                                const QStringList &extraArgs)
@@ -567,7 +567,7 @@ VcsCommand *VcsBasePluginPrivate::createInitialCheckoutCommand(const QString &ur
     return nullptr;
 }
 
-bool VcsBasePluginPrivate::enableMenuAction(ActionState as, QAction *menuAction) const
+bool VersionControlBase::enableMenuAction(ActionState as, QAction *menuAction) const
 {
     qCDebug(baseLog) << "enableMenuAction" << menuAction->text() << as;
     switch (as) {
@@ -588,42 +588,42 @@ bool VcsBasePluginPrivate::enableMenuAction(ActionState as, QAction *menuAction)
     return true;
 }
 
-QString VcsBasePluginPrivate::commitDisplayName() const
+QString VersionControlBase::commitDisplayName() const
 {
     //: Name of the "commit" action of the VCS
     return Tr::tr("Commit", "name of \"commit\" action of the VCS.");
 }
 
-QString VcsBasePluginPrivate::commitAbortTitle() const
+QString VersionControlBase::commitAbortTitle() const
 {
     return Tr::tr("Close Commit Editor");
 }
 
-QString VcsBasePluginPrivate::commitAbortMessage() const
+QString VersionControlBase::commitAbortMessage() const
 {
     return Tr::tr("Closing this editor will abort the commit.");
 }
 
-QString VcsBasePluginPrivate::commitErrorMessage(const QString &error) const
+QString VersionControlBase::commitErrorMessage(const QString &error) const
 {
     if (error.isEmpty())
         return Tr::tr("Cannot commit.");
     return Tr::tr("Cannot commit: %1.").arg(error);
 }
 
-void VcsBasePluginPrivate::commitFromEditor()
+void VersionControlBase::commitFromEditor()
 {
     QTC_ASSERT(m_submitEditor, return);
     m_submitEditor->accept(this);
 }
 
-bool VcsBasePluginPrivate::promptBeforeCommit()
+bool VersionControlBase::promptBeforeCommit()
 {
     return DocumentManager::saveAllModifiedDocuments(Tr::tr("Save before %1?")
                                                      .arg(commitDisplayName().toLower()));
 }
 
-void VcsBasePluginPrivate::promptToDeleteCurrentFile()
+void VersionControlBase::promptToDeleteCurrentFile()
 {
     const VcsBasePluginState state = currentState();
     QTC_ASSERT(state.hasFile(), return);
@@ -642,7 +642,7 @@ static inline bool ask(QWidget *parent, const QString &title, const QString &que
     return QMessageBox::question(parent, title, question, QMessageBox::Yes|QMessageBox::No, defaultButton) == QMessageBox::Yes;
 }
 
-void VcsBasePluginPrivate::createRepository()
+void VersionControlBase::createRepository()
 {
     QTC_ASSERT(supportsOperation(IVersionControl::CreateRepositoryOperation), return);
     // Find current starting directory
@@ -679,17 +679,17 @@ void VcsBasePluginPrivate::createRepository()
     }
 }
 
-void VcsBasePluginPrivate::setSubmitEditor(VcsBaseSubmitEditor *submitEditor)
+void VersionControlBase::setSubmitEditor(VcsBaseSubmitEditor *submitEditor)
 {
     m_submitEditor = submitEditor;
 }
 
-VcsBaseSubmitEditor *VcsBasePluginPrivate::submitEditor() const
+VcsBaseSubmitEditor *VersionControlBase::submitEditor() const
 {
     return m_submitEditor;
 }
 
-bool VcsBasePluginPrivate::raiseSubmitEditor() const
+bool VersionControlBase::raiseSubmitEditor() const
 {
     if (!m_submitEditor)
         return false;
@@ -697,7 +697,7 @@ bool VcsBasePluginPrivate::raiseSubmitEditor() const
     return true;
 }
 
-void VcsBasePluginPrivate::discardCommit()
+void VersionControlBase::discardCommit()
 {
 }
 
diff --git a/src/plugins/vcsbase/vcsbaseplugin.h b/src/plugins/vcsbase/vcsbaseplugin.h
index 5a4c9ae6b3..b1c9abf32a 100644
--- a/src/plugins/vcsbase/vcsbaseplugin.h
+++ b/src/plugins/vcsbase/vcsbaseplugin.h
@@ -30,7 +30,7 @@ namespace VcsBase {
 namespace Internal { class State; }
 
 class VcsBaseSubmitEditor;
-class VcsBasePluginPrivate;
+class VersionControlBase;
 class VcsBasePluginStateData;
 class VcsCommand;
 
@@ -87,7 +87,7 @@ public:
     { return !s1.equals(s2); }
 
 private:
-    friend class VcsBasePluginPrivate;
+    friend class VersionControlBase;
     bool equals(const Internal::State &s) const;
     void setState(const Internal::State &s);
 
@@ -111,12 +111,12 @@ VCSBASE_EXPORT void setSource(Core::IDocument *document, const Utils::FilePath &
 // Returns the source of editor contents.
 VCSBASE_EXPORT Utils::FilePath source(Core::IDocument *document);
 
-class VCSBASE_EXPORT VcsBasePluginPrivate : public Core::IVersionControl
+class VCSBASE_EXPORT VersionControlBase : public Core::IVersionControl
 {
     Q_OBJECT
 
 protected:
-    explicit VcsBasePluginPrivate(const Core::Context &context);
+    explicit VersionControlBase(const Core::Context &context);
 
 public:
     void extensionsInitialized();
diff --git a/src/plugins/vcsbase/vcsbasesubmiteditor.cpp b/src/plugins/vcsbase/vcsbasesubmiteditor.cpp
index 70d0ec4b8a..7eb3673a4e 100644
--- a/src/plugins/vcsbase/vcsbasesubmiteditor.cpp
+++ b/src/plugins/vcsbase/vcsbasesubmiteditor.cpp
@@ -436,7 +436,7 @@ void VcsBaseSubmitEditor::setDescriptionMandatory(bool v)
 
 enum { checkDialogMinimumWidth = 500 };
 
-void VcsBaseSubmitEditor::accept(VcsBasePluginPrivate *plugin)
+void VcsBaseSubmitEditor::accept(VersionControlBase *plugin)
 {
     auto submitWidget = static_cast<SubmitEditorWidget *>(this->widget());
 
@@ -457,7 +457,7 @@ void VcsBaseSubmitEditor::close()
     EditorManager::closeDocuments({document()});
 }
 
-bool VcsBaseSubmitEditor::promptSubmit(VcsBasePluginPrivate *plugin)
+bool VcsBaseSubmitEditor::promptSubmit(VersionControlBase *plugin)
 {
     if (d->m_disablePrompt)
         return true;
diff --git a/src/plugins/vcsbase/vcsbasesubmiteditor.h b/src/plugins/vcsbase/vcsbasesubmiteditor.h
index 2c3123d736..29351a1cb2 100644
--- a/src/plugins/vcsbase/vcsbasesubmiteditor.h
+++ b/src/plugins/vcsbase/vcsbasesubmiteditor.h
@@ -21,7 +21,7 @@ namespace Internal { class SubmitEditorFile; }
 
 class SubmitEditorWidget;
 class SubmitFileModel;
-class VcsBasePluginPrivate;
+class VersionControlBase;
 class VcsBaseSubmitEditorPrivate;
 
 class VCSBASE_EXPORT VcsBaseSubmitEditorParameters
@@ -47,8 +47,8 @@ public:
 
     ~VcsBaseSubmitEditor() override;
 
-    void accept(VcsBasePluginPrivate *plugin);
-    bool promptSubmit(VcsBasePluginPrivate *plugin);
+    void accept(VersionControlBase *plugin);
+    bool promptSubmit(VersionControlBase *plugin);
 
     QAbstractItemView::SelectionMode fileListSelectionMode() const;
     void setFileListSelectionMode(QAbstractItemView::SelectionMode sm);
diff --git a/src/plugins/vcsbase/wizard/vcscommandpage.cpp b/src/plugins/vcsbase/wizard/vcscommandpage.cpp
index 0877e3ffbe..c24cdfce0e 100644
--- a/src/plugins/vcsbase/wizard/vcscommandpage.cpp
+++ b/src/plugins/vcsbase/wizard/vcscommandpage.cpp
@@ -260,7 +260,7 @@ void VcsCommandPage::delayedInitialize()
     QTC_ASSERT(wiz, return);
 
     const QString vcsId = wiz->expander()->expand(m_vcsId);
-    VcsBasePluginPrivate *vc = static_cast<VcsBasePluginPrivate *>(
+    VersionControlBase *vc = static_cast<VersionControlBase *>(
                 VcsManager::versionControl(Id::fromString(vcsId)));
     if (!vc) {
         qWarning() << Tr::tr("\"%1\" (%2) not found.")