aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins
diff options
context:
space:
mode:
authorEike Ziller <eike.ziller@qt.io>2024-04-25 14:35:00 +0200
committerEike Ziller <eike.ziller@qt.io>2024-04-26 12:15:07 +0000
commitee1db27251b785d757ba4c1512972b3a5ed1eb3c (patch)
tree36bf6ac5d9cf702274302518a278e0c0550d208f /src/plugins
parent925b224c6d75c36601f15d5eb309405bfcab92ca (diff)
FancyTabWidget: Remove an old, unnecessary hack
When clicking on a mode button, the emission of `currentChanged` was delayed by an event. That was supposedly to "improve the responsiveness" of the mode bar, but I don't see any difference, and _if_ changing the mode widget was a performance issue, this wouldn't be the right place to fix or work around it. The hack creates issues, because it separates the `currentAboutToChange` and `currentChanged` signals by an event processing. Amends bd2ba2307b5695a3856c01ea478066e411ca6256 Change-Id: I53a7aa74fdcfb733a28574837ca9e95fc2e97f0b Reviewed-by: David Schulz <david.schulz@qt.io>
Diffstat (limited to 'src/plugins')
-rw-r--r--src/plugins/coreplugin/fancytabwidget.cpp5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/plugins/coreplugin/fancytabwidget.cpp b/src/plugins/coreplugin/fancytabwidget.cpp
index 39b0eaccb7..05fb7e3e13 100644
--- a/src/plugins/coreplugin/fancytabwidget.cpp
+++ b/src/plugins/coreplugin/fancytabwidget.cpp
@@ -196,10 +196,7 @@ void FancyTabBar::mousePressEvent(QMouseEvent *event)
emit currentAboutToChange(index);
m_currentIndex = index;
update();
- // update tab bar before showing widget
- QMetaObject::invokeMethod(this, [this] {
- emit currentChanged(m_currentIndex);
- }, Qt::QueuedConnection);
+ emit currentChanged(m_currentIndex);
}
}
}