QMake make step: Remove unused signal

User arguments could not change behind the configuration UI's back, so
no need to inform it about changes.

Change-Id: Id03d61c6f0b5abcd9bed50504a518554d08eae78
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

2 files changed, 0 insertions, 19 deletions

diff --git a/src/plugins/qmakeprojectmanager/makestep.cpp b/src/plugins/qmakeprojectmanager/makestep.cpp
index 5195bba0a0..7944010a68 100644
--- a/src/plugins/qmakeprojectmanager/makestep.cpp
+++ b/src/plugins/qmakeprojectmanager/makestep.cpp
@@ -285,7 +285,6 @@ QString MakeStep::userArguments()
 void MakeStep::setUserArguments(const QString &arguments)
 {
     m_userArgs = arguments;
-    emit userArgumentsChanged();
 }
 
 MakeStepConfigWidget::MakeStepConfigWidget(MakeStep *makeStep)
@@ -308,9 +307,6 @@ MakeStepConfigWidget::MakeStepConfigWidget(MakeStep *makeStep)
     connect(m_ui->makeArgumentsLineEdit, &QLineEdit::textEdited,
             this, &MakeStepConfigWidget::makeArgumentsLineEdited);
 
-    connect(makeStep, &MakeStep::userArgumentsChanged,
-            this, &MakeStepConfigWidget::userArgumentsChanged);
-
     BuildConfiguration *bc = makeStep->buildConfiguration();
     if (!bc) {
         // That means the step is in the deploylist, so we listen to the active build config
@@ -430,14 +426,6 @@ QString MakeStepConfigWidget::displayName() const
     return m_makeStep->displayName();
 }
 
-void MakeStepConfigWidget::userArgumentsChanged()
-{
-    if (m_ignoreChange)
-        return;
-    m_ui->makeArgumentsLineEdit->setText(m_makeStep->userArguments());
-    updateDetails();
-}
-
 void MakeStepConfigWidget::makeEdited()
 {
     m_makeStep->setMakeCommand(m_ui->makePathChooser->rawPath());
@@ -446,9 +434,7 @@ void MakeStepConfigWidget::makeEdited()
 
 void MakeStepConfigWidget::makeArgumentsLineEdited()
 {
-    m_ignoreChange = true;
     m_makeStep->setUserArguments(m_ui->makeArgumentsLineEdit->text());
-    m_ignoreChange = false;
     updateDetails();
 }
 
diff --git a/src/plugins/qmakeprojectmanager/makestep.h b/src/plugins/qmakeprojectmanager/makestep.h
index 075b50e1b7..79ba75c396 100644
--- a/src/plugins/qmakeprojectmanager/makestep.h
+++ b/src/plugins/qmakeprojectmanager/makestep.h
@@ -75,9 +75,6 @@ public:
 
     QVariantMap toMap() const override;
 
-signals:
-    void userArgumentsChanged();
-
 private:
     bool fromMap(const QVariantMap &map) override;
 
@@ -105,7 +102,6 @@ private:
     void makeArgumentsLineEdited();
 
     void updateDetails();
-    void userArgumentsChanged();
     void activeBuildConfigurationChanged();
     void setSummaryText(const QString &text);
 
@@ -113,7 +109,6 @@ private:
     MakeStep *m_makeStep = nullptr;
     QString m_summaryText;
     ProjectExplorer::BuildConfiguration *m_bc = nullptr;
-    bool m_ignoreChange = false;
 };
 
 } // QmakeProjectManager