1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
|
// Copyright (C) 2019 The Qt Company Ltd.
// Copyright (C) 2019 Christoph Schlosser, B/S/H/ <christoph.schlosser@bshg.com>
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0+ OR GPL-3.0 WITH Qt-GPL-exception-1.0
#include "addvalueoperation.h"
#include "addkeysoperation.h"
#include "getoperation.h"
#include "rmkeysoperation.h"
#include <iomanip>
#include <iostream>
#ifdef WITH_TESTS
#include <QTest>
#endif
#include <QLoggingCategory>
#include <QRegularExpression>
Q_LOGGING_CATEGORY(addvaluelog, "qtc.sdktool.operations.addvalue", QtWarningMsg)
namespace {
constexpr auto SUCCESS = 0;
constexpr auto FAILURE = !SUCCESS;
} // namespace
QString AddValueOperation::name() const
{
return QLatin1String("addValue");
}
QString AddValueOperation::helpText() const
{
return QLatin1String("add a value to an existing list");
}
QString AddValueOperation::argumentsHelpText() const
{
return QLatin1String(
"A file (relative to top-level settings directory and without .xml extension)\n"
"followed by the key of the list followed by one or more type:values to append to the "
"list.\n");
}
bool AddValueOperation::setArguments(const QStringList &args)
{
if (args.size() < 3) {
std::cerr << "Error: No";
switch (args.size()) {
case 0:
std::cerr << " file,";
Q_FALLTHROUGH();
case 1:
std::cerr << " key and";
Q_FALLTHROUGH();
case 2:
std::cerr << " values";
break;
}
std::cerr << " given.\n" << std::endl;
return false;
}
auto tempArgs = args;
m_file = tempArgs.takeFirst();
m_key = tempArgs.takeFirst();
for (const auto &arg : tempArgs) {
const auto val = valueFromString(arg);
if (!val.isValid() || val.isNull()) {
std::cerr << "Error: " << std::quoted(arg.toStdString())
<< " is not a valid QVariant like string Type:Value.\n"
<< std::endl;
return false;
}
m_values.append(val);
}
return true;
}
int AddValueOperation::execute() const
{
auto map = load(m_file);
if (map.empty()) {
std::cerr << "Error: Could not load " << m_file.toStdString() << std::endl;
return FAILURE;
}
bool status = appendListToMap(map);
if (status) {
status = save(map, m_file);
}
return status ? SUCCESS : FAILURE;
}
#ifdef WITH_TESTS
void AddValueOperation::unittest()
{
QVariantList testDataList;
testDataList.append(QLatin1String("Some String"));
testDataList.append(int(1860));
KeyValuePairList testKvpList;
testKvpList.append(KeyValuePair(QLatin1String("test/foo"), QString::fromLatin1("QString:Foo")));
testKvpList.append(KeyValuePair(QLatin1String("test/foobar"), QString::fromLatin1("int:42")));
testKvpList.append(KeyValuePair(QLatin1String("test/bar"), testDataList));
const QVariantList valueList = {valueFromString("QString:ELIL"), valueFromString("int:-1")};
QVariantMap testMap;
// add to empty map
AddValueData d;
d.m_key = "some key";
d.m_values = valueList;
QTest::ignoreMessage(QtCriticalMsg,
QRegularExpression("Error: Could not retrieve value for key .*."));
QVERIFY(!d.appendListToMap(testMap));
testMap.insert(QLatin1String("someEmptyThing"), QVariantMap());
testMap.insert(QLatin1String("aKey"), "withAString");
// append to a value
d.m_key = "aKey";
QTest::ignoreMessage(QtCriticalMsg,
QRegularExpression("Error: Data stored in .* is not a QVariantList."));
QVERIFY(!d.appendListToMap(testMap));
testMap = AddKeysData{testKvpList}.addKeys(testMap);
// quick sanity check
QCOMPARE(testMap.count(), 3);
QCOMPARE(testDataList.count(), 2);
QCOMPARE(testKvpList.count(), 3);
// successful adding of values
d.m_key = "test/bar";
QVERIFY(d.appendListToMap(testMap));
const auto newList = qvariant_cast<QVariantList>(GetOperation::get(testMap, "test/bar"));
QCOMPARE(newList.count(), (testDataList.count() + valueList.count()));
QVERIFY(newList.contains(1860));
QVERIFY(newList.contains(QString("Some String")));
QVERIFY(newList.contains("ELIL"));
QVERIFY(newList.contains(-1));
}
#endif
bool AddValueData::appendListToMap(QVariantMap &map) const
{
const QVariant data = GetOperation::get(map, m_key);
if (!data.isValid() || data.isNull()) {
qCCritical(addvaluelog) << "Error: Could not retrieve value for key"
<< m_key;
return false;
}
if (data.type() != QVariant::List) {
qCCritical(addvaluelog) << "Error: Data stored in" << m_key
<< "is not a QVariantList.";
return false;
}
auto newList = qvariant_cast<QVariantList>(data);
newList.append(m_values);
map = RmKeysOperation::rmKeys(map, {m_key});
map = AddKeysData{{{m_key, newList}}}.addKeys(map);
return true;
}
|
