diff options
| author | Katja Marttila <katja.marttila@qt.io> | 2024-04-04 15:35:20 +0300 |
|---|---|---|
| committer | Katja Marttila <katja.marttila@qt.io> | 2024-04-09 07:40:55 +0000 |
| commit | 18ddeeb7fa29ff9dc95570200bf574eb11aca928 (patch) | |
| tree | 4c993d4d20e2d9dd6a00ab0526238492c61ffd82 /src/libs/installer/packagemanagercore.cpp | |
| parent | 06b16edfb00d60ee5b17b7156f6f313e3bd6b1a9 (diff) | |
Fix occasional crash in install phase
Progress information is printed using same static instance of the
coordinator by different operations. The operation object pointer was saved as key to QHash so that progress could be tracked. This has caused problems in installer as QHash insert occasionally caused segmentation fault.
Fixed so that the progress information is no longer tracked based on
operation object pointer, instead object name is used.
Task-number: QTIFW-3314
Change-Id: Ic4007f226321e109109006c5c89415308920c614
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
Diffstat (limited to 'src/libs/installer/packagemanagercore.cpp')
| -rw-r--r-- | src/libs/installer/packagemanagercore.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp index 509b8a757..2fb39a4a8 100644 --- a/src/libs/installer/packagemanagercore.cpp +++ b/src/libs/installer/packagemanagercore.cpp @@ -853,7 +853,7 @@ int PackageManagerCore::downloadNeededArchives(double partProgressSize) ProgressCoordinator::instance()->emitLabelAndDetailTextChanged(QLatin1Char('\n') + tr("Downloading packages...")); - DownloadArchivesJob archivesJob(this); + DownloadArchivesJob archivesJob(this, QLatin1String("downloadArchiveJob")); archivesJob.setAutoDelete(false); archivesJob.setArchivesToDownload(archivesToDownload); archivesJob.setExpectedTotalSize(archivesToDownloadTotalSize); |