diff options
| author | Katja Marttila <katja.marttila@qt.io> | 2022-12-28 11:19:31 +0200 |
|---|---|---|
| committer | Katja Marttila <katja.marttila@qt.io> | 2023-01-26 08:05:14 +0200 |
| commit | 476b6d6fffaf6841adaf68889e8b8ddae17dd382 (patch) | |
| tree | 48d804c0a596b14afa395a35841c684f0b7d56c3 /src/libs/installer/packagemanagercore.cpp | |
| parent | 1b4b466af7ff89dc00b9f81686933fbbb82561c7 (diff) | |
Resolve downloadable archive list while installing
Installer can have thousands of components and only few of them user
selects for install. Parsing the downloadable archives to install only
when they are selected for install for better performance.
Task-number: QTIFW-2805
Change-Id: I0771df05e17c85f37639768e2581d85bbf7bf66f
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
Diffstat (limited to 'src/libs/installer/packagemanagercore.cpp')
| -rw-r--r-- | src/libs/installer/packagemanagercore.cpp | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp index 642f13b03..8c70bdae6 100644 --- a/src/libs/installer/packagemanagercore.cpp +++ b/src/libs/installer/packagemanagercore.cpp @@ -3977,14 +3977,8 @@ bool PackageManagerCore::updateComponentData(struct Data &data, Component *compo component->setValue(QLatin1String("password"), repo.password()); } - // add downloadable archive from xml - const QStringList downloadableArchives = data.package->data(scDownloadableArchives).toString() - .split(QInstaller::commaRegExp(), Qt::SkipEmptyParts); - - if (component->isFromOnlineRepository()) { - foreach (const QString downloadableArchive, downloadableArchives) - component->addDownloadableArchive(downloadableArchive); - } + if (component->isFromOnlineRepository()) + component->addDownloadableArchives(data.package->data(scDownloadableArchives).toString()); const QStringList componentsToReplace = data.package->data(scReplaces).toString() .split(QInstaller::commaRegExp(), Qt::SkipEmptyParts); |