diff options
| author | Katja Marttila <katja.marttila@qt.io> | 2023-01-24 09:36:19 +0200 |
|---|---|---|
| committer | Katja Marttila <katja.marttila@qt.io> | 2023-02-07 13:18:06 +0200 |
| commit | bd1a4717be131c7850848e4995bc75b600f6cabe (patch) | |
| tree | 95a396e67d1545bd286aedbd5d47d6e22f387fd9 /src/libs/installer/packagemanagercore.cpp | |
| parent | cc477fbe8ab7133c7ce1cd636e2b0d833e739c90 (diff) | |
Optimize QString::split usage
To increase efficiency QString::split is performed only to strings
which are not empty.
Task-number: QTIFW-2805
Change-Id: Ieed887a3e6f415395497dcdf05c118b32c72d9ee
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
Diffstat (limited to 'src/libs/installer/packagemanagercore.cpp')
| -rw-r--r-- | src/libs/installer/packagemanagercore.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp index 2f69c20c8..d5758438d 100644 --- a/src/libs/installer/packagemanagercore.cpp +++ b/src/libs/installer/packagemanagercore.cpp @@ -4021,9 +4021,7 @@ bool PackageManagerCore::updateComponentData(struct Data &data, Component *compo if (component->isFromOnlineRepository()) component->addDownloadableArchives(data.package->data(scDownloadableArchives).toString()); - const QStringList componentsToReplace = data.package->data(scReplaces).toString() - .split(QInstaller::commaRegExp(), Qt::SkipEmptyParts); - + const QStringList componentsToReplace = QInstaller::splitStringWithComma(data.package->data(scReplaces).toString()); if (!componentsToReplace.isEmpty()) { // Store the component (this is a component that replaces others) and all components that // this one will replace. |