aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Tismer <tismer@stackless.com>2024-04-04 10:31:56 +0200
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2024-04-04 13:38:26 +0000
commitb0be45b239043cd776ed888e0aff54866af913c5 (patch)
treef289bb2b94bcfdda944c26abaf36fa8dabdf6db1
parentc989d58e9e39104d4b948511d1eb26db44364449 (diff)
signature: Fix an old refcounting bug6.6
This bug was a long existing oversight since 2018-10-14 ! amends 2533dab013455bf94da2d4766e54abaf4d735e1e This bug has been hiding undetected for a really long time between innocent lines of code since version 5.15. But now someone has finally uncovered it and it will be brought to justice. Actually, I should be ashamed of myself. Thanks to Joris van Rantwijk for finding this glitch. Change-Id: Id86db1caea8c18c3a2d4d1707c0101fe8aa3d6d8 Task-number: PYSIDE-795 Fixes: PYSIDE-2660 Pick-to: 6.5 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> (cherry picked from commit f89113e21645b5076d47b656140f0ceecf35fa09) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 8b302d296a58cba9a43c93aca06fad4526a7d13e)
-rw-r--r--sources/shiboken6/libshiboken/signature/signature_extend.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/sources/shiboken6/libshiboken/signature/signature_extend.cpp b/sources/shiboken6/libshiboken/signature/signature_extend.cpp
index ca560d00f..7292f8216 100644
--- a/sources/shiboken6/libshiboken/signature/signature_extend.cpp
+++ b/sources/shiboken6/libshiboken/signature/signature_extend.cpp
@@ -77,7 +77,7 @@ PyObject *pyside_md_get___signature__(PyObject *ob_md, PyObject *modifier)
{
AutoDecRef func(name_key_to_func(ob_md));
if (func.object() == Py_None)
- return Py_None;
+ Py_RETURN_NONE;
if (func.isNull())
Py_FatalError("missing mapping in MethodDescriptor");
return pyside_cf_get___signature__(func, modifier);