feature: Fix a flag error when no snake_case is selected

This is another small bug that was found by testing
true_property alone. Some flag refactoring forgot to mask
the flag.

Change-Id: Id3576cf982451b022a8ace72fbaf4369d32b6cb1
Task-number: PYSIDE-1019
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
(cherry picked from commit cdb644bc8fde3086996d4ecaba06f8c34d7666a3)
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>

1 files changed, 4 insertions, 3 deletions

diff --git a/sources/shiboken2/libshiboken/bindingmanager.cpp b/sources/shiboken2/libshiboken/bindingmanager.cpp
index 78c03556c..065c02049 100644
--- a/sources/shiboken2/libshiboken/bindingmanager.cpp
+++ b/sources/shiboken2/libshiboken/bindingmanager.cpp
@@ -299,12 +299,13 @@ PyObject *BindingManager::getOverride(const void *cptr,
         // They cannot be overridden (make that sure by the metaclass).
         return nullptr;
     }
-    PyObject *pyMethodName = nameCache[(flag & 1) != 0];  // borrowed
+    bool is_snake = flag & 0x01;
+    PyObject *pyMethodName = nameCache[is_snake];  // borrowed
     if (pyMethodName == nullptr) {
         if (propFlag)
             methodName += 2;    // skip the propFlag and ':'
-        pyMethodName = Shiboken::String::getSnakeCaseName(methodName, flag);
-        nameCache[(flag & 1) != 0] = pyMethodName;
+        pyMethodName = Shiboken::String::getSnakeCaseName(methodName, is_snake);
+        nameCache[is_snake] = pyMethodName;
     }
 
     if (wrapper->ob_dict) {