build: avoid mutable default value as argument

Mainly to avoid having a persistent object every time
we call the function, to avoid future issues.

Pick-to: 6.2 6.3
Change-Id: I9aea45ffa7ecd381e8c5ed6b3c83036d6e8aef72
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>

1 files changed, 8 insertions, 2 deletions

diff --git a/build_scripts/utils.py b/build_scripts/utils.py
index 0c69ba87c..6a8eaa054 100644
--- a/build_scripts/utils.py
+++ b/build_scripts/utils.py
@@ -615,8 +615,8 @@ def macos_fix_rpaths_for_library(library_path, qt_lib_dir):
     macos_add_qt_rpath(library_path, qt_lib_dir, existing_rpath_commands, install_names)
 
 
-def macos_add_qt_rpath(library_path, qt_lib_dir, existing_rpath_commands=[],
-                       library_dependencies=[]):
+def macos_add_qt_rpath(library_path, qt_lib_dir, existing_rpath_commands=None,
+                       library_dependencies=None):
     """
     Adds an rpath load command to the Qt lib directory if necessary
 
@@ -624,6 +624,12 @@ def macos_add_qt_rpath(library_path, qt_lib_dir, existing_rpath_commands=[],
     and adds an rpath load command that points to the Qt lib directory
     (qt_lib_dir).
     """
+    if existing_rpath_commands is None:
+        existing_rpath_commands = []
+
+    if library_dependencies is None:
+        library_dependencies = []
+
     if not existing_rpath_commands:
         existing_rpath_commands = macos_get_rpaths(library_path)