build: Address fixme comment in utils.py

Use subprocess.run() instead of Popen().

Task-number: PYSIDE-802
Task-number: PYSIDE-962
Change-Id: I9504303c1fbc4ecc4f1fbdaae4886a3fbd0788a0
Reviewed-by: Christian Tismer <tismer@stackless.com>

1 files changed, 4 insertions, 9 deletions

diff --git a/build_scripts/utils.py b/build_scripts/utils.py
index fd9b8f71d..1a5a86dfe 100644
--- a/build_scripts/utils.py
+++ b/build_scripts/utils.py
@@ -1258,16 +1258,11 @@ def configure_cmake_project(project_path,
         cmd.extend([f'-D{arg}={value}'])
 
     cmd_string = ' '.join(cmd)
-    # FIXME Python 3.7: Use subprocess.run()
-    proc = subprocess.Popen(cmd,
-                            stdout=subprocess.PIPE,
-                            stderr=subprocess.PIPE,
-                            shell=False,
-                            cwd=build_path,
-                            universal_newlines=True)
-    output, error = proc.communicate()
-    proc.wait()
+    proc = subprocess.run(cmd, shell=False, cwd=build_path,
+                          capture_output=True, universal_newlines=True)
     return_code = proc.returncode
+    output = proc.stdout
+    error = proc.stderr
 
     if return_code != 0:
         raise RuntimeError(f"\nFailed to configure CMake project \n "