Optimize my dumb code that do stuff with a QByteArray without knowing if will use it.

1 files changed, 4 insertions, 3 deletions

diff --git a/libpyside/pysidesignal.cpp b/libpyside/pysidesignal.cpp
index b4940d5e8..9b8cbc076 100644
--- a/libpyside/pysidesignal.cpp
+++ b/libpyside/pysidesignal.cpp
@@ -783,11 +783,12 @@ void registerSignals(SbkObjectType* pyObj, const QMetaObject* metaObject)
     SignalSigMap signalsFound;
     for(int i = metaObject->methodOffset(), max = metaObject->methodCount(); i < max; ++i) {
         QMetaMethod method = metaObject->method(i);
-        QByteArray methodName(method.signature());
-        methodName.chop(methodName.size() - methodName.indexOf('('));
 
-        if (method.methodType() == QMetaMethod::Signal)
+        if (method.methodType() == QMetaMethod::Signal) {
+            QByteArray methodName(method.signature());
+            methodName.chop(methodName.size() - methodName.indexOf('('));
             signalsFound[methodName] << join(method.parameterTypes(), ",");
+        }
     }
 
     SignalSigMap::Iterator it = signalsFound.begin();