Cleanup pointer whitespace everywhere

Among other files to fix, basewrapper.(cpp|h) was full of uncommon
pointer whitespace. After fixing that, I could not resist and fixed
also libshiboken, generators, and after acceptance also PySide.

Most of the time, this regex worked fine

   (\w\w+)([*&]+)[ ]*(?![&*]*[/=])

replaced with

    \1 \2

but everything was checked by hand.

I did not touch the shiboken tests which are quite hairy.

It turned out that inserting a space between a variable and asterisk
causes a crash of shiboken, if the same line contains "CONVERTTOCPP".
This was temporarily fixed by adding another space after it.
Example..

sources/pyside2/PySide2/glue/qtcore.cpp line 977

    QByteArray * cppSelf = %CONVERTTOCPP[QByteArray *](obj);
    //XXX      /|\ omitting this space crashes shiboken!

cppgenerator.cpp was special, since it was modified to _generate_
correct pointer whitespace. This caused a few testcases to fail,
which had to be adjusted, again. This was difficult since some
internal names must end on "*" and generated code normally not.
Removing the last errors involved binary search on path sets...

Apply C++ 11 fixits to the changed code, where applicable.

Done-with: Friedemann.Kleint@qt.io
Task-number: PYSIDE-1037
Change-Id: I4ac070f52c5efb296c05d581c9d46e6f397a6c81
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
 
 

1 files changed, 7 insertions, 7 deletions

diff --git a/sources/pyside2/PySide2/QtCore/glue/qeasingcurve_glue.h b/sources/pyside2/PySide2/QtCore/glue/qeasingcurve_glue.h
index 358ea9eec..f6c80fa99 100644
--- a/sources/pyside2/PySide2/QtCore/glue/qeasingcurve_glue.h
+++ b/sources/pyside2/PySide2/QtCore/glue/qeasingcurve_glue.h
@@ -38,7 +38,7 @@
 ****************************************************************************/
 
 #ifndef __QEASINGCURVE_GLUE__
-#define __QEASINGCURVE_GLUE__ 
+#define __QEASINGCURVE_GLUE__
 
 #include <sbkpython.h>
 #include <QEasingCurve>
@@ -47,20 +47,20 @@ class PySideEasingCurveFunctor
 {
     public:
         static void init();
-        static QEasingCurve::EasingFunction createCustomFuntion(PyObject* parent, PyObject* pyFunc);
+        static QEasingCurve::EasingFunction createCustomFuntion(PyObject *parent, PyObject *pyFunc);
 
         qreal operator()(qreal progress);
 
-        PyObject* callable(); //Return New reference 
-        static PyObject* callable(PyObject* parent); //Return New reference 
+        PyObject *callable(); //Return New reference
+        static PyObject *callable(PyObject *parent); //Return New reference
 
         ~PySideEasingCurveFunctor();
     private:
-        PyObject* m_parent;
-        PyObject* m_func;
+        PyObject *m_parent;
+        PyObject *m_func;
         int m_index;
 
-        PySideEasingCurveFunctor(int index, PyObject* parent, PyObject *pyFunc);
+        PySideEasingCurveFunctor(int index, PyObject *parent, PyObject *pyFunc);
 };
 
 #endif