libpyside: Fix clang-tidy warnings about class definitions

- Add override
- Use = default for trivial constructors/destructors
- Add Q_DISABLE_COPY where applicable
- Use member initialization and remove constructors from simple structs
- Use explicit where applicable (which requires adapting code snippets
  constructing a QVariant from PyObjectWrapper)
- Fix some parameter to take a const ref or pass by value
  and use std::move in constructors

Change-Id: I5e0d2c4ef92d20397a7daba2f8a64b507e678510
Reviewed-by: Christian Tismer <tismer@stackless.com>

1 files changed, 7 insertions, 10 deletions

diff --git a/sources/pyside2/libpyside/dynamicqmetaobject.cpp b/sources/pyside2/libpyside/dynamicqmetaobject.cpp
index 4cc915be7..2d567d99b 100644
--- a/sources/pyside2/libpyside/dynamicqmetaobject.cpp
+++ b/sources/pyside2/libpyside/dynamicqmetaobject.cpp
@@ -111,16 +111,13 @@ public:
 
     QMap<QByteArray, QByteArray> m_info;
     QByteArray m_className;
-    bool m_updated; // when the meta data is not update
-    int m_methodOffset;
-    int m_propertyOffset;
-    int m_dataSize;
-    int m_emptyMethod;
-    int m_nullIndex;
 
-    DynamicQMetaObjectPrivate()
-        : m_updated(false), m_methodOffset(0), m_propertyOffset(0),
-          m_dataSize(0), m_emptyMethod(-1), m_nullIndex(0) {}
+    bool m_updated = false; // when the meta data is not update
+    int m_methodOffset = 0;
+    int m_propertyOffset = 0;
+    int m_dataSize = 0;
+    int m_emptyMethod = -1;
+    int m_nullIndex = 0;
 
     int createMetaData(QMetaObject* metaObj, QLinkedList<QByteArray> &strings);
     void updateMetaObject(QMetaObject* metaObj);
@@ -527,7 +524,7 @@ void DynamicQMetaObject::addInfo(const char* key, const char* value)
     m_d->m_info[key] = value;
 }
 
-void DynamicQMetaObject::addInfo(QMap<QByteArray, QByteArray> info)
+void DynamicQMetaObject::addInfo(const QMap<QByteArray, QByteArray> &info)
 {
     QMap<QByteArray, QByteArray>::const_iterator i = info.constBegin();
     while (i != info.constEnd()) {