diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-09-12 10:47:02 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-09-12 11:24:12 +0000 |
| commit | 248ab8c8740de3e0adb203dd207862b35cfc69fe (patch) | |
| tree | beb15a490d986a515cae72c34e034267b21bc03d /sources/pyside2/libpyside/globalreceiverv2.cpp | |
| parent | 0187d2b17dd5d35d645b70a2cf08c7100c0d6a14 (diff) | |
libpyside: Fix contains()/value() antipattern
Use iterators instead, avoiding repeated lookups of hashes and maps.
Change-Id: I3b430bdf0ceef1980baeca45849880d35538e89b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources/pyside2/libpyside/globalreceiverv2.cpp')
| -rw-r--r-- | sources/pyside2/libpyside/globalreceiverv2.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/sources/pyside2/libpyside/globalreceiverv2.cpp b/sources/pyside2/libpyside/globalreceiverv2.cpp index 5b8785563..0c30f2c5f 100644 --- a/sources/pyside2/libpyside/globalreceiverv2.cpp +++ b/sources/pyside2/libpyside/globalreceiverv2.cpp @@ -155,9 +155,8 @@ PyObject* DynamicSlotDataV2::callback() int DynamicSlotDataV2::id(const char* signature) const { - if (m_signatures.contains(signature)) - return m_signatures[signature]; - return -1; + const auto it = m_signatures.constFind(signature); + return it != m_signatures.cend() ? it.value() : -1; } int DynamicSlotDataV2::addSlot(const char* signature) |