libpyside: Fix clang-tidy warnings about class definitions

- Add override
- Use = default for trivial constructors/destructors
- Add Q_DISABLE_COPY where applicable
- Use member initialization and remove constructors from simple structs
- Use explicit where applicable (which requires adapting code snippets
  constructing a QVariant from PyObjectWrapper)
- Fix some parameter to take a const ref or pass by value
  and use std::move in constructors

Change-Id: I5e0d2c4ef92d20397a7daba2f8a64b507e678510
Reviewed-by: Christian Tismer <tismer@stackless.com>

1 files changed, 9 insertions, 6 deletions

diff --git a/sources/pyside2/libpyside/pysidesignal.cpp b/sources/pyside2/libpyside/pysidesignal.cpp
index 2d135e557..1052bbfb2 100644
--- a/sources/pyside2/libpyside/pysidesignal.cpp
+++ b/sources/pyside2/libpyside/pysidesignal.cpp
@@ -1,3 +1,5 @@
+#include <utility>
+
 /****************************************************************************
 **
 ** Copyright (C) 2016 The Qt Company Ltd.
@@ -54,14 +56,15 @@ namespace Signal {
     //aux
     class SignalSignature {
     public:
-        SignalSignature() : m_attributes(QMetaMethod::Compatibility) {}
-        SignalSignature(QByteArray parameterTypes) : m_parameterTypes(parameterTypes),
-            m_attributes(QMetaMethod::Compatibility) {}
-        SignalSignature(QByteArray parameterTypes, QMetaMethod::Attributes attributes) :
-            m_parameterTypes(parameterTypes),
+        SignalSignature() = default;
+        explicit SignalSignature(QByteArray parameterTypes) :
+            m_parameterTypes(std::move(parameterTypes)) {}
+        explicit SignalSignature(QByteArray parameterTypes, QMetaMethod::Attributes attributes) :
+            m_parameterTypes(std::move(parameterTypes)),
             m_attributes(attributes) {}
+
         QByteArray m_parameterTypes;
-        QMetaMethod::Attributes m_attributes;
+        QMetaMethod::Attributes m_attributes = QMetaMethod::Compatibility;
     };
 
     static char*        buildSignature(const char*, const char*);