libpyside: Fix clang-tidy warnings about class definitions

- Add override
- Use = default for trivial constructors/destructors
- Add Q_DISABLE_COPY where applicable
- Use member initialization and remove constructors from simple structs
- Use explicit where applicable (which requires adapting code snippets
  constructing a QVariant from PyObjectWrapper)
- Fix some parameter to take a const ref or pass by value
  and use std::move in constructors

Change-Id: I5e0d2c4ef92d20397a7daba2f8a64b507e678510
Reviewed-by: Christian Tismer <tismer@stackless.com>

1 files changed, 2 insertions, 5 deletions

diff --git a/sources/pyside2/libpyside/signalmanager.h b/sources/pyside2/libpyside/signalmanager.h
index 22aea37c3..c4d57c333 100644
--- a/sources/pyside2/libpyside/signalmanager.h
+++ b/sources/pyside2/libpyside/signalmanager.h
@@ -54,7 +54,7 @@ class PYSIDE_API PyObjectWrapper
 {
 public:
     PyObjectWrapper();
-    PyObjectWrapper(PyObject* me);
+    explicit PyObjectWrapper(PyObject* me);
     PyObjectWrapper(const PyObjectWrapper &other);
     ~PyObjectWrapper();
     operator PyObject*() const;
@@ -68,6 +68,7 @@ PYSIDE_API QDataStream &operator>>(QDataStream& in, PyObjectWrapper& myObj);
 
 class PYSIDE_API SignalManager
 {
+    Q_DISABLE_COPY(SignalManager)
 public:
     static SignalManager& instance();
 
@@ -109,10 +110,6 @@ private:
 
     SignalManager();
     ~SignalManager();
-
-    // disable copy
-    SignalManager(const SignalManager&);
-    SignalManager operator=(const SignalManager&);
 };
 
 }