aboutsummaryrefslogtreecommitdiffstats
path: root/sources/pyside2/tests/QtNetwork/bug_446.py
diff options
context:
space:
mode:
authorBoxiang Sun <daetalusun@gmail.com>2018-05-20 11:04:45 +0800
committerBoxiang Sun <daetalusun@gmail.com>2018-06-01 15:09:19 +0000
commitee8e7117c79f6820cb228e0f0da522ce7d3c1dce (patch)
tree13cd0847be4ff45a80e2457b945f86b9bd9b4a20 /sources/pyside2/tests/QtNetwork/bug_446.py
parentddbd93680730811a5020b4d429c2e3e11d6823e3 (diff)
Improve the QByteArray implementation
The available constructors for QByteArray are now: bytes, bytearray, and QByteArray, unicode is not accepted anymore. Also the concatenation is now possible between QByteArrays. Even though is not possible to initialize a QByteArray with an unicode, we include the possibility to compare it with one (Compatibility with PyQt). The __repr__ and __str__ are now properly working. There seemed to be a confusion regarding data types between Shiboken, Python2 and Python3 related to bytes, so now the structure is based on the flag SBK_BYTES_NAME, which is define as "bytes" for Python3 and "str" for Python2. Many tests were modified to properly handle string, using the `py3kcompat` module. Task-number: PYSIDE-232 Change-Id: I8b671f367c60a0870c72dcbe5662106b3225037d Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'sources/pyside2/tests/QtNetwork/bug_446.py')
-rw-r--r--sources/pyside2/tests/QtNetwork/bug_446.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/sources/pyside2/tests/QtNetwork/bug_446.py b/sources/pyside2/tests/QtNetwork/bug_446.py
index da4e27d42..4fcda65b7 100644
--- a/sources/pyside2/tests/QtNetwork/bug_446.py
+++ b/sources/pyside2/tests/QtNetwork/bug_446.py
@@ -32,10 +32,11 @@ from PySide2.QtCore import *
from PySide2.QtNetwork import *
from helper import UsesQCoreApplication
+import py3kcompat as py3k
class HttpSignalsCase(UsesQCoreApplication):
'''Test case for launching QHttp signals'''
- DATA = "PySide rocks"
+ DATA = py3k.b("PySide rocks")
def onError(self):
self.assertTrue(False)
@@ -48,7 +49,7 @@ class HttpSignalsCase(UsesQCoreApplication):
def onReadReady(self):
data = self.client.read(100)
- self.assertEqual(data.size(), len(HttpSignalsCase.DATA))
+ self.assertEqual(len(data), len(HttpSignalsCase.DATA))
self.assertEqual(data, HttpSignalsCase.DATA)
self.done()