diff options
author | Christian Tismer <tismer@stackless.com> | 2020-02-13 13:35:03 +0100 |
---|---|---|
committer | Christian Tismer <tismer@stackless.com> | 2020-02-21 15:14:18 +0100 |
commit | d579912b31d7cfa7b0b216916fbbf3eb632a9d9d (patch) | |
tree | 0e206543adc1781003c39bdf8627af09cbe9270f /sources/pyside2/tests/QtWidgets/bug_750.py | |
parent | f69d163d17d3717c28f2c065173113756d7c50ef (diff) |
Turn qApp into a normal Python variable, finally
After a long odyssey of more or less unpythonic compromizes,
the qApp "macro" would finally be moved into a normal
variable without surprizes.
This was only possible since we removed qApp from QtWidgets
and other modules. Otherwise,
from PySide2.QtWidgets import *
would pull qApp, being the constant "None", into main and
shadow the true qApp variable in the builtins.
By inserting qApp into the builtins, only, we make sure that
this variable is always freshly looked up, without making it
change its contents.
DONE...
+ change the singleton code to normal
+ rename to MakeQAppWrapper
+ simplify the implementation
+ fix new bug concerning duplicate applications
+ check very much for refcounting bugs
+ review the rest of the implementation and further simplify
Note... The Q*Application variable will not be turned back into
a GC variable. This is not worth the effort.
Fixes: PYSIDE-571
Change-Id: Idbd158c083318e6b0dfe48d62485c68c90e944de
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Diffstat (limited to 'sources/pyside2/tests/QtWidgets/bug_750.py')
-rw-r--r-- | sources/pyside2/tests/QtWidgets/bug_750.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sources/pyside2/tests/QtWidgets/bug_750.py b/sources/pyside2/tests/QtWidgets/bug_750.py index 42b6c9843..78d333efd 100644 --- a/sources/pyside2/tests/QtWidgets/bug_750.py +++ b/sources/pyside2/tests/QtWidgets/bug_750.py @@ -36,7 +36,7 @@ from helper.usesqapplication import UsesQApplication from PySide2.QtCore import QTimer from PySide2.QtGui import QPainter, QFont, QFontInfo -from PySide2.QtWidgets import QWidget, qApp +from PySide2.QtWidgets import QWidget class MyWidget(QWidget): def paintEvent(self, e): |