Fix some clang-tidy warnings in shiboken

- 'else if' after return/break/continue
- Use const ref for complex arguments passed by value where possible
- Fix 'if (foo) delete foo' to 'delete foo'
- Use container.isEmpty() instead of container.size() in checks
- Use ' = default' for trivial constructors/destructors
- Use range based for where possible
- Complete constructor initializer lists
- Fix invocations of static methods
- Replace some reinterpret_cast by static_cast
- Remove unused variables/fields
- Use initializer lists for return types

Change-Id: Id5b44a2f9d429f66ef069d532a1cd31df796d38e
Reviewed-by: Christian Tismer <tismer@stackless.com>

1 files changed, 9 insertions, 8 deletions

diff --git a/sources/shiboken2/ApiExtractor/docparser.cpp b/sources/shiboken2/ApiExtractor/docparser.cpp
index 9305332ba..ce089c1f5 100644
--- a/sources/shiboken2/ApiExtractor/docparser.cpp
+++ b/sources/shiboken2/ApiExtractor/docparser.cpp
@@ -50,9 +50,7 @@ DocParser::DocParser()
 #endif
 }
 
-DocParser::~DocParser()
-{
-}
+DocParser::~DocParser() = default;
 
 QString DocParser::getDocumentation(QXmlQuery& xquery, const QString& query,
                                     const DocModificationList& mods) const
@@ -154,13 +152,16 @@ QString DocParser::msgCannotFindDocumentation(const QString &fileName,
 namespace
 {
 
-struct XslResources
+class XslResources
 {
-    xmlDocPtr xmlDoc;
-    xsltStylesheetPtr xslt;
-    xmlDocPtr xslResult;
+    Q_DISABLE_COPY(XslResources)
+
+public:
+    xmlDocPtr xmlDoc = nullptr;
+    xsltStylesheetPtr xslt = nullptr;
+    xmlDocPtr xslResult = nullptr;
 
-    XslResources() : xmlDoc(0), xslt(0), xslResult(0) {}
+    XslResources() = default;
 
     ~XslResources()
     {