diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2020-10-22 08:59:03 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2020-10-27 10:01:34 +0000 |
| commit | 8b88410f9f9589235738bb26739d40af4447cc05 (patch) | |
| tree | 19276bec219bf2a3c728fdced77b8fb3a45063fc /sources/shiboken2/ApiExtractor/tests/testmodifyfunction.cpp | |
| parent | 49bd2b28d4a666107d4d124b9a5cc9fbe88d8fe8 (diff) | |
shiboken2: AbstractMetaArgument: use QSharedData[Pointer]
Similar to AbstractMetaType, AbstractMetaArgument was previously
kept as a raw pointer. The data were copied numerous times by
AbstractMetaArgument::copy() when adding the inherited functions to a
AbstractMetaClass.
Similar to what was done for AbstractMetaType in
6cad0686101b252cfdbd1a6768a2b02c39aa1d8a, change the type to be based
on QSharedData[Pointer]. It can then be passed around and treated like
a C++ value type, with Qt sharing the data when possible behind the
scenes.
* Remove inheritance from AbstractMetaVariable by moving
the fields over.
* Remove the unused field m_originalName.
Change-Id: Ic9e476ca71e163de131fbecc267d0a4e336cb0b9
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources/shiboken2/ApiExtractor/tests/testmodifyfunction.cpp')
| -rw-r--r-- | sources/shiboken2/ApiExtractor/tests/testmodifyfunction.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sources/shiboken2/ApiExtractor/tests/testmodifyfunction.cpp b/sources/shiboken2/ApiExtractor/tests/testmodifyfunction.cpp index cca0370e6..d88ad5397 100644 --- a/sources/shiboken2/ApiExtractor/tests/testmodifyfunction.cpp +++ b/sources/shiboken2/ApiExtractor/tests/testmodifyfunction.cpp @@ -311,10 +311,10 @@ void TestModifyFunction::testGlobalFunctionModification() const AbstractMetaFunction *func = builder->globalFunctions().constFirst(); QVERIFY(func); QCOMPARE(func->arguments().count(), 1); - const AbstractMetaArgument *arg = func->arguments().constFirst(); - QCOMPARE(arg->type().cppSignature(), QLatin1String("A *")); - QCOMPARE(arg->originalDefaultValueExpression(), QLatin1String("0")); - QCOMPARE(arg->defaultValueExpression(), QLatin1String("A()")); + const AbstractMetaArgument &arg = func->arguments().constFirst(); + QCOMPARE(arg.type().cppSignature(), QLatin1String("A *")); + QCOMPARE(arg.originalDefaultValueExpression(), QLatin1String("0")); + QCOMPARE(arg.defaultValueExpression(), QLatin1String("A()")); } // Tests modifications of exception handling and allow-thread |