shiboken2: MetaBuilder/ApiExtractor/Generator: Return class/enum/function lists by const ref

This allows for removing a few temporary variables and/or qAsConst().

Task-number: PYSIDE-1075
Change-Id: I0fe3544f0ce4d3a8d56de9c93e300972e0844177
Reviewed-by: Christian Tismer <tismer@stackless.com>

4 files changed, 18 insertions, 18 deletions

diff --git a/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp b/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp
index 4197c4cfa..b46ed5092 100644
--- a/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp
+++ b/sources/shiboken2/ApiExtractor/abstractmetabuilder.cpp
@@ -135,27 +135,27 @@ AbstractMetaBuilder::~AbstractMetaBuilder()
     delete d;
 }
 
-AbstractMetaClassList AbstractMetaBuilder::classes() const
+const AbstractMetaClassList &AbstractMetaBuilder::classes() const
 {
     return d->m_metaClasses;
 }
 
-AbstractMetaClassList AbstractMetaBuilder::templates() const
+const AbstractMetaClassList &AbstractMetaBuilder::templates() const
 {
     return d->m_templates;
 }
 
-AbstractMetaClassList AbstractMetaBuilder::smartPointers() const
+const AbstractMetaClassList &AbstractMetaBuilder::smartPointers() const
 {
     return d->m_smartPointers;
 }
 
-AbstractMetaFunctionList AbstractMetaBuilder::globalFunctions() const
+const AbstractMetaFunctionList &AbstractMetaBuilder::globalFunctions() const
 {
     return d->m_globalFunctions;
 }
 
-AbstractMetaEnumList AbstractMetaBuilder::globalEnums() const
+const AbstractMetaEnumList &AbstractMetaBuilder::globalEnums() const
 {
     return d->m_globalEnums;
 }
diff --git a/sources/shiboken2/ApiExtractor/abstractmetabuilder.h b/sources/shiboken2/ApiExtractor/abstractmetabuilder.h
index 37022a544..d2dc080a2 100644
--- a/sources/shiboken2/ApiExtractor/abstractmetabuilder.h
+++ b/sources/shiboken2/ApiExtractor/abstractmetabuilder.h
@@ -63,11 +63,11 @@ public:
     AbstractMetaBuilder();
     virtual ~AbstractMetaBuilder();
 
-    AbstractMetaClassList classes() const;
-    AbstractMetaClassList templates() const;
-    AbstractMetaClassList smartPointers() const;
-    AbstractMetaFunctionList globalFunctions() const;
-    AbstractMetaEnumList globalEnums() const;
+    const AbstractMetaClassList &classes() const;
+    const AbstractMetaClassList &templates() const;
+    const AbstractMetaClassList &smartPointers() const;
+    const AbstractMetaFunctionList &globalFunctions() const;
+    const AbstractMetaEnumList &globalEnums() const;
     AbstractMetaEnum *findEnum(const TypeEntry *typeEntry) const;
 
     /**
diff --git a/sources/shiboken2/ApiExtractor/apiextractor.cpp b/sources/shiboken2/ApiExtractor/apiextractor.cpp
index 530ed0252..3fdd613ae 100644
--- a/sources/shiboken2/ApiExtractor/apiextractor.cpp
+++ b/sources/shiboken2/ApiExtractor/apiextractor.cpp
@@ -121,25 +121,25 @@ void ApiExtractor::setDropTypeEntries(QString dropEntries)
     TypeDatabase::instance()->setDropTypeEntries(entries);
 }
 
-AbstractMetaEnumList ApiExtractor::globalEnums() const
+const AbstractMetaEnumList &ApiExtractor::globalEnums() const
 {
     Q_ASSERT(m_builder);
     return m_builder->globalEnums();
 }
 
-AbstractMetaFunctionList ApiExtractor::globalFunctions() const
+const AbstractMetaFunctionList &ApiExtractor::globalFunctions() const
 {
     Q_ASSERT(m_builder);
     return m_builder->globalFunctions();
 }
 
-AbstractMetaClassList ApiExtractor::classes() const
+const AbstractMetaClassList &ApiExtractor::classes() const
 {
     Q_ASSERT(m_builder);
     return m_builder->classes();
 }
 
-AbstractMetaClassList ApiExtractor::smartPointers() const
+const AbstractMetaClassList &ApiExtractor::smartPointers() const
 {
     Q_ASSERT(m_builder);
     return m_builder->smartPointers();
diff --git a/sources/shiboken2/ApiExtractor/apiextractor.h b/sources/shiboken2/ApiExtractor/apiextractor.h
index f6dd2ba8e..b0c2c696f 100644
--- a/sources/shiboken2/ApiExtractor/apiextractor.h
+++ b/sources/shiboken2/ApiExtractor/apiextractor.h
@@ -81,10 +81,10 @@ public:
     LanguageLevel languageLevel() const;
     void setLanguageLevel(LanguageLevel languageLevel);
 
-    AbstractMetaEnumList globalEnums() const;
-    AbstractMetaFunctionList globalFunctions() const;
-    AbstractMetaClassList classes() const;
-    AbstractMetaClassList smartPointers() const;
+    const AbstractMetaEnumList &globalEnums() const;
+    const AbstractMetaFunctionList &globalFunctions() const;
+    const AbstractMetaClassList &classes() const;
+    const AbstractMetaClassList &smartPointers() const;
     AbstractMetaClassList classesTopologicalSorted(const Dependencies &additionalDependencies = Dependencies()) const;
     PrimitiveTypeEntryList primitiveTypes() const;
     ContainerTypeEntryList containerTypes() const;