shiboken: Constify GeneratorContext

Pass around by const-ref and return a const pointer to the class.

In HeaderGenerator::generateClass(), make a copy of the context
passed in to prevent writing back via reference in the base
class loop.

Change-Id: I0338bd93b5a53c25ec18bc45b407ab67d8c7c91e
Reviewed-by: Christian Tismer <tismer@stackless.com>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>

1 files changed, 4 insertions, 3 deletions

diff --git a/sources/shiboken2/generator/shiboken2/headergenerator.cpp b/sources/shiboken2/generator/shiboken2/headergenerator.cpp
index 70a24bd3c..235ea003d 100644
--- a/sources/shiboken2/generator/shiboken2/headergenerator.cpp
+++ b/sources/shiboken2/generator/shiboken2/headergenerator.cpp
@@ -45,7 +45,7 @@ QString HeaderGenerator::fileNameSuffix() const
     return QLatin1String("_wrapper.h");
 }
 
-QString HeaderGenerator::fileNameForContext(GeneratorContext &context) const
+QString HeaderGenerator::fileNameForContext(const GeneratorContext &context) const
 {
     const AbstractMetaClass *metaClass = context.metaClass();
     if (!context.forSmartPointer()) {
@@ -91,9 +91,10 @@ void HeaderGenerator::writeProtectedFieldAccessors(QTextStream &s, const Abstrac
       << " { " << fieldName << " = value; }\n";
 }
 
-void HeaderGenerator::generateClass(QTextStream &s, GeneratorContext &classContext)
+void HeaderGenerator::generateClass(QTextStream &s, const GeneratorContext &classContextIn)
 {
-    AbstractMetaClass *metaClass = classContext.metaClass();
+    GeneratorContext classContext = classContextIn;
+    const AbstractMetaClass *metaClass = classContext.metaClass();
     m_inheritedOverloads.clear();
     Indentation indent(INDENT);