diff options
author | Christian Tismer <tismer@stackless.com> | 2019-11-26 11:54:37 +0100 |
---|---|---|
committer | Christian Tismer <tismer@stackless.com> | 2019-12-05 08:28:22 +0100 |
commit | 45a3efb4e179e83f1bea69cccb190945fbc8c1f8 (patch) | |
tree | 0cefe123ffdc876b933d2c76185098d2dd9c7eae /sources/shiboken2/libshiboken/typespec.cpp | |
parent | 6f79beb23aace35170d155517b9d901567a7f675 (diff) |
Fix Python 3.8 problems
This patch fixes some refcounting problems with Python 3.8 .
One incompatible change was announced in the what's new
document, but actually there were two more problems which
were not explicitly mentioned but took much time to sort out.
The patch is compatible with the limited API changes
(tested with debug build and API error disabled).
It is also independent of the Python version which is
full Limited API support.
For more info, see the documentation mentioned below.
The flag error is circumvented now! We either find a better
solution or leave it as it is. For now this is ok.
Fixes: PYSIDE-939
Change-Id: Iff4a9816857a6ebe86efd4b654d8921e4e464939
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Diffstat (limited to 'sources/shiboken2/libshiboken/typespec.cpp')
-rw-r--r-- | sources/shiboken2/libshiboken/typespec.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sources/shiboken2/libshiboken/typespec.cpp b/sources/shiboken2/libshiboken/typespec.cpp index 510ed51e6..902ed55af 100644 --- a/sources/shiboken2/libshiboken/typespec.cpp +++ b/sources/shiboken2/libshiboken/typespec.cpp @@ -714,7 +714,7 @@ PyType_FromSpecWithBases(PyType_Spec *spec, PyObject *bases) if (PyType_Ready(type) < 0) goto fail; - // no ht_hached_keys in Python 2 + // no ht_cached_keys in Python 2 // if (type->tp_dictoffset) { // res->ht_cached_keys = _PyDict_NewKeysForClass(); // } |