shiboken6: Remove function attribute FinalInTargetLang

The attribute does not have any impact on the generated code; it merely
causes some warnings to be printed when fixing the class functions
for rare cases. AbstractMetaFunction::isModifiedFinal() determines
the generation of virtual functions instead.

The function query flags FinalInTargetLangFunctions and
VirtualInTargetLangFunctions can be removed as well. They were
both used in AbstractMetaClass::functionsInTargetLang() which
is used by the documentation generator only.

Pick-to: 6.7
Task-number: PYSIDE-2602
Change-Id: Ib0f0de41008b655a84637ab28f1046aa3e098b76
Reviewed-by: Christian Tismer <tismer@stackless.com>

1 files changed, 1 insertions, 11 deletions

diff --git a/sources/shiboken6/ApiExtractor/abstractmetabuilder.cpp b/sources/shiboken6/ApiExtractor/abstractmetabuilder.cpp
index 4de9be38d..8d84d09b7 100644
--- a/sources/shiboken6/ApiExtractor/abstractmetabuilder.cpp
+++ b/sources/shiboken6/ApiExtractor/abstractmetabuilder.cpp
@@ -386,7 +386,6 @@ bool AbstractMetaBuilderPrivate::traverseStreamOperator(const FunctionModelItem
 
     streamFunction->setArguments(arguments);
 
-    *streamFunction += AbstractMetaFunction::FinalInTargetLang;
     streamFunction->setAccess(Access::Public);
 
     AbstractMetaClassPtr funcClass;
@@ -1561,11 +1560,6 @@ void AbstractMetaBuilderPrivate::applyFunctionModifications(AbstractMetaFunction
             else if (mod.isPrivate())
                 funcRef.modifyAccess(Access::Private);
         }
-
-        if (mod.isFinal())
-            funcRef += AbstractMetaFunction::FinalInTargetLang;
-        else if (mod.isNonFinal())
-            funcRef -= AbstractMetaFunction::FinalInTargetLang;
     }
 }
 
@@ -2091,14 +2085,10 @@ AbstractMetaFunction *AbstractMetaBuilderPrivate::traverseFunction(const Functio
             *metaFunction += AbstractMetaFunction::OverriddenCppMethod;
         if (functionItem->isFinal())
             *metaFunction += AbstractMetaFunction::FinalCppMethod;
-    } else {
-        *metaFunction += AbstractMetaFunction::FinalInTargetLang;
     }
 
-    if (functionItem->isStatic()) {
+    if (functionItem->isStatic())
         *metaFunction += AbstractMetaFunction::Static;
-        *metaFunction += AbstractMetaFunction::FinalInTargetLang;
-    }
 
     // Access rights
     metaFunction->setAccess(functionItem->accessPolicy());