aboutsummaryrefslogtreecommitdiffstats
path: root/sources/shiboken6/libshiboken/basewrapper.cpp
diff options
context:
space:
mode:
authorChristian Tismer <tismer@stackless.com>2023-09-05 18:41:42 +0200
committerChristian Tismer <tismer@stackless.com>2023-09-06 08:23:20 +0200
commitaf98eac426c0cee4003ac45bf0fcfcabccf0e9f2 (patch)
tree6a1a6fa8d4684b1157c5cc10a01cf7c44f320485 /sources/shiboken6/libshiboken/basewrapper.cpp
parent0c3a3cd7923a9903b2d482594f27dd27e04b0c42 (diff)
PyPySide: Fix a small, very old glitch
Many years ago (2012), the format string of SbkObjectType_tp_new contained the string "SO!O!:sbktype". The meaning of this "S" is redundant for historical reasons and means PyObject. It is equal to "O". At some unknown point in time, this "S" was erroneously turned into "s", which means a plain string. Unfortunately, this neat finding does not solve the multiple inheritance problem of PyPy, but this will surely be found at some point, too. Change-Id: I51045216f9c0aa2c9efdda06a2ad5f9ac64e9696 Task-number: PYSIDE-535 Pick-to: 6.5 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'sources/shiboken6/libshiboken/basewrapper.cpp')
-rw-r--r--sources/shiboken6/libshiboken/basewrapper.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/sources/shiboken6/libshiboken/basewrapper.cpp b/sources/shiboken6/libshiboken/basewrapper.cpp
index 9e5d1b89e..a0e4e5311 100644
--- a/sources/shiboken6/libshiboken/basewrapper.cpp
+++ b/sources/shiboken6/libshiboken/basewrapper.cpp
@@ -476,7 +476,7 @@ static PyTypeObject *SbkObjectType_tp_new(PyTypeObject *metatype, PyObject *args
PyObject *dict;
static const char *kwlist[] = { "name", "bases", "dict", nullptr};
- if (!PyArg_ParseTupleAndKeywords(args, kwds, "sO!O!:sbktype", const_cast<char **>(kwlist),
+ if (!PyArg_ParseTupleAndKeywords(args, kwds, "OO!O!:sbktype", const_cast<char **>(kwlist),
&name,
&PyTuple_Type, &pyBases,
&PyDict_Type, &dict))