diff options
author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2022-12-19 14:09:23 +0100 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2022-12-22 09:30:08 +0100 |
commit | 1930ac417cc24ed74842e1a6f1c751ce2cfc47d0 (patch) | |
tree | 78387dc7d565b1124a874c13074d929022be69aa /sources/shiboken6/tests/libsample/modifications.h | |
parent | 8cc5d64cf80f918b75366e148c7a951404b2313b (diff) |
Fix coding style of the shiboken tests
- Place star/reference correctly
- Fix include order
- Streamline code, wrap long lines
- Use member initialization and default special methods
Change-Id: I7b7e7d8e8c9562cd932bee8144bc44d6b2dda0a5
Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io>
Reviewed-by: Adrian Herrmann <adrian.herrmann@qt.io>
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources/shiboken6/tests/libsample/modifications.h')
-rw-r--r-- | sources/shiboken6/tests/libsample/modifications.h | 22 |
1 files changed, 12 insertions, 10 deletions
diff --git a/sources/shiboken6/tests/libsample/modifications.h b/sources/shiboken6/tests/libsample/modifications.h index d757d87b9..0dea163b6 100644 --- a/sources/shiboken6/tests/libsample/modifications.h +++ b/sources/shiboken6/tests/libsample/modifications.h @@ -5,10 +5,11 @@ #define MODIFICATIONS_H #include "libsamplemacros.h" -#include <utility> #include "point.h" #include "oddbool.h" +#include <utility> + class ObjectType; class LIBSAMPLE_API Modifications @@ -61,10 +62,10 @@ public: // 'ok' must be removed and the return value will be changed // to a tuple (PyObject*) containing the expected result plus // the 'ok' value as a Python boolean - std::pair<double, double> pointToPair(Point pt, bool* ok); + std::pair<double, double> pointToPair(Point pt, bool *ok); // same as 'pointToPair' except that this time 'ok' is the first argument - double multiplyPointCoordsPlusValue(bool* ok, Point pt, double value); + double multiplyPointCoordsPlusValue(bool *ok, Point pt, double value); // completely remove 'plus' from the Python side int doublePlus(int value, int plus = 0); @@ -85,24 +86,25 @@ public: int cppMultiply(int a, int b); // change the name of this virtual method - virtual const char* className(); + virtual const char *className(); Point sumPointArray(int arraySize, const Point pointArray[]); // Replace 'const void*' by 'ByteArray&'. - int getSize(const void* data, int size); + int getSize(const void *data, int size); // Mark the argument with a <no-null-pointer/> tag; // the test implementation must expect point never to be null. - int sumPointCoordinates(const Point* point); + int sumPointCoordinates(const Point *point); // Modify the return value of a virtual method. - virtual double differenceOfPointCoordinates(const Point* pt, bool* ok); - double callDifferenceOfPointCoordinates(const Point* pt, bool* ok) { return differenceOfPointCoordinates(pt, ok); } + virtual double differenceOfPointCoordinates(const Point *pt, bool *ok); + double callDifferenceOfPointCoordinates(const Point *pt, bool *ok) + { return differenceOfPointCoordinates(pt, ok); } // Sets an ObjectType in the argument and returns true. bool nonConversionRuleForArgumentWithDefaultValue(ObjectType **object = nullptr); - ObjectType* getObject() const { return m_object; } + ObjectType *getObject() const { return m_object; } // Inject code with a %CONVERTTOPYTHON that receives an user's primitive type. static inline OddBool passOddBool(OddBool ob) { return ob; } @@ -118,7 +120,7 @@ public: void notifySetAttroCalled(); private: - ObjectType* m_object; + ObjectType *m_object; TestEnum m_enumValue = TestEnumValue1; bool m_getAttroCalled = false; bool m_setAttroCalled = false; |