aboutsummaryrefslogtreecommitdiffstats
path: root/sources
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@qt.io>2022-05-04 09:38:15 +0200
committerFriedemann Kleint <Friedemann.Kleint@qt.io>2022-05-09 12:24:06 +0200
commitfaebfdad1f47f83caac29dd1854bdfb2cba9c671 (patch)
tree4d52889d0e23196270b5d1456ea89123d1df24f0 /sources
parentfc5f4eb973593ee5c26247e0502100c462b1fe7b (diff)
PySide6: Fix bool(QByteArray(b"")) to return False
bool(QByteArray(b"")) currently returns True due to QByteArray::isNull(), which is out of line with the Python convention that "" yields False. Disable the isNull() handling to fix this. [ChangeLog][PySide6] The bool cast for QByteArray has been changed to return False for empty byte arrays to match the expected behavior. Fixes: PYSIDE-1913 Change-Id: I197bf1553bd0335ded213f377f657cedc2af03fc Reviewed-by: Shyamnath Premnadh <Shyamnath.Premnadh@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Diffstat (limited to 'sources')
-rw-r--r--sources/pyside6/PySide6/QtCore/typesystem_core_common.xml4
1 files changed, 3 insertions, 1 deletions
diff --git a/sources/pyside6/PySide6/QtCore/typesystem_core_common.xml b/sources/pyside6/PySide6/QtCore/typesystem_core_common.xml
index 29f9cdd8b..daa266f3a 100644
--- a/sources/pyside6/PySide6/QtCore/typesystem_core_common.xml
+++ b/sources/pyside6/PySide6/QtCore/typesystem_core_common.xml
@@ -1859,7 +1859,9 @@
</add-function>
</value-type>
- <value-type name="QByteArray">
+ <!-- PYSIDE-1913: Disable isNull() for bool cast; __len__ should be used
+ instead so that b"" yields False. -->
+ <value-type name="QByteArray" isNull="false">
<enum-type name="Base64Option" flags="Base64Options" since="5.2"/>
<enum-type name="Base64DecodingStatus" since="5.15"/>
<value-type name="FromBase64Result" since="5.15"/>