Fixes bug #910 - installEventFilter() increments reference count on target object.

http://bugs.pyside.org/show_bug.cgi?id=910

Also added/fixed unit tests.

Reviewed by Hugo Parente <hugo.lima@openbossa.org>
Reviewed by Luciano Wolf <luciano.wolf@openbossa.org>

1 files changed, 36 insertions, 0 deletions

diff --git a/tests/QtCore/qobject_event_filter_test.py b/tests/QtCore/qobject_event_filter_test.py
index 8018fcda0..8fded7983 100644
--- a/tests/QtCore/qobject_event_filter_test.py
+++ b/tests/QtCore/qobject_event_filter_test.py
@@ -2,6 +2,8 @@
 '''Test cases for QObject.eventFilter'''
 
 import unittest
+import weakref
+import sys
 
 from PySide.QtCore import QObject, QTimerEvent
 
@@ -76,5 +78,39 @@ class TestQObjectEventFilterPython(UsesQCoreApplication):
         self.assertEqual(filtered.times_called, 5)
         self.assertEqual(self.obj_filter.events_handled, 5)
 
+    def testInstallEventFilterRefCountAfterDelete(self):
+        '''Bug 910 - installEventFilter() increments reference count on target object
+        http://bugs.pyside.org/show_bug.cgi?id=910'''
+        obj = QObject()
+        filt = QObject()
+
+        self.assertEqual(sys.getrefcount(obj), 2)
+        self.assertEqual(sys.getrefcount(filt), 2)
+        obj.installEventFilter(filt)
+        self.assertEqual(sys.getrefcount(obj), 2)
+        self.assertEqual(sys.getrefcount(filt), 2)
+
+        wref = weakref.ref(obj)
+        del obj
+        self.assertEqual(wref(), None)
+
+    def testInstallEventFilterRefCountAfterRemove(self):
+        # Bug 910
+        obj = QObject()
+        filt = QObject()
+
+        self.assertEqual(sys.getrefcount(obj), 2)
+        self.assertEqual(sys.getrefcount(filt), 2)
+        obj.installEventFilter(filt)
+        self.assertEqual(sys.getrefcount(obj), 2)
+        self.assertEqual(sys.getrefcount(filt), 2)
+        obj.removeEventFilter(filt)
+        self.assertEqual(sys.getrefcount(obj), 2)
+        self.assertEqual(sys.getrefcount(filt), 2)
+
+        wref = weakref.ref(obj)
+        del obj
+        self.assertEqual(wref(), None)
+
 if __name__ == '__main__':
     unittest.main()