aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib/corelib/buildgraph
Commit message (Collapse)AuthorAgeFilesLines
* Add faster setJsProperty overloadHEADmasterIvan Komissarov9 hours1-5/+8
| | | | | | | | | | | | | | | | | | It is not necessary to allocate a temp QString when prop name is known at compile time. This saves one allocation when creating js arrays/stringLists from QVariant. ========== Performance data for Resolving ========== Old instruction count: 10343055373 New instruction count: 10327497420 Relative change: -1 % Old peak memory usage: 111906792 Bytes New peak memory usage: 113268160 Bytes Relative change: +1 % Change-Id: I813eb674bf4e04b5c64dbb22d09cc68a54ced9e1 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Commands: Print more details when a command is cancelledChristian Kandeler10 days3-6/+18
| | | | | | | | Namely, command description, program (if any) and product. Fixes: QBS-1750 Change-Id: I7df6281aec41021a9332a44fa35ee0fa1dd33a83 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* RulesApplicator: Do not auto-correct invalid artifact pathsChristian Kandeler2024-05-101-8/+9
| | | | | | | | | If a rule tries to create an artifact outside the build directory, complain instead of (sometimes) silently changing it. Fixes: QBS-1268 Change-Id: I9b5e27cf01b01fd7d09254083279682888838f83 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* clang-tidy: fix 'bugprone-assignment-in-if-condition'Ivan Komissarov2024-02-261-3/+8
| | | | | Change-Id: Ia53f439a73abcdcbc7fb743739280cfa489fa66a Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* clang-tidy: fix 'modernize-return-braced-init-list'Ivan Komissarov2024-02-231-1/+1
| | | | | Change-Id: Ie7eccb76937b6dfbf754ea30710be5825168d50d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* BuildGraphLoader: Be more transparent about why we re-resolveChristian Kandeler2024-02-162-20/+38
| | | | | | | It's annoying for users not to know why that happened. Change-Id: Ibee5257a66afe9a3bf287d85c72fe93d452a3b38 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* Language server: Add completion supportChristian Kandeler2024-02-085-22/+24
| | | | | | | | | | This feature uncovered some sloppiness in our handling of QVariant types, which has now been fixed. Task-number: QBS-395 Change-Id: I687cef7470d97fe7887e4a7a1dbe672b2b9c79ec Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com> Reviewed-by: David Schulz <david.schulz@qt.io>
* Consolidate expansion and modification test in SourceWildcardRichard Weickelt2023-11-011-19/+5
| | | | | | | | | | | | | | In order to make use of SourceWildcard in other contexts, any special relationship to ResolvedGroup is now removed. All information needed to re-expand the wildcards is stored inside the object. The re-expansion test has been moved into the class and the API has been simplified. SourceArtifact objects, no matter if wildcard-based or not are now stored inside ResolvedGroup and are marked by a boolean flag. Task-number: QBS-1749 Change-Id: I53bf2776685b5abf4713341387d1efa23ad316b2 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Merge 2.2 into masterChristian Kandeler2023-10-271-1/+3
|\ | | | | | | Change-Id: I20763ec5ea0f96f01837b59b76e7bfcbcbf681e2
| * BuildGraphLoader: Reset expanded build config dataChristian Kandeler2023-10-161-1/+3
| | | | | | | | | | | | | | | | | | ... after updating the top-level profile. Otherwise we will continue with properties from the wrong profile. Fixes: QBS-1765 Change-Id: I9723dd38739fac350453417e76b7f2da5e4495c2 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* | Remove dependency of SourceWildCards on ResolvedGroupRichard Weickelt2023-10-161-1/+1
|/ | | | | | | | | | | | | | SourceWildCards had an unnecessary dependency on ResolvedGroup which could be a historical relic. However, it is functionally independent and can be useful in other contexts as well, for example wildcard project references. We really do not want to duplicate the complicated wildcard expansion code. This patch is a first step in a refactoring series. Task-number: QBS-1749 Change-Id: I2ce0e784d4668f7cee686cd4c2101aef3ce38eda Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Make scan scripts interruptibleChristian Kandeler2023-10-022-8/+4
| | | | | | Fixes: QBS-785 Change-Id: I5aeb24419e2ff2831105ae2a07d2d325dc0583f1 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* Bump minimum Qt versionChristian Kandeler2023-09-121-1/+1
| | | | | | | | There's no need to drop Qt 5 just yet, but we should require the latest version. Change-Id: I2653ef5c3c244453db88a48d59e2c86eb38518b5 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* Loader: Merge the remains of ProjectTreeBuilder into ProjectResolverChristian Kandeler2023-05-311-2/+2
| | | | | | | | This will enable us to get rid of redundant data structures and the two- phase product handling. Change-Id: I8a9f5e06b216f7b8cd8842acfbcf77edc30fadb4 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* Port from qAsConst() to std::as_const()Marc Mutz2023-05-2216-95/+95
| | | | | | | | | | | | | | QBS has been requiring C++17 since at least 1.18, probably earlier. Providing qAsConst() is finally starting to bother Qt (QTBUG-99313), so time to port away from it now. Since qAsConst has exactly the same semantics as std::as_const (down to rvalue treatment, constexpr'ness and noexcept'ness), there's really nothing more to it than a global search-and-replace. Task-number: QTBUG-99313 Change-Id: I51154f8c5d283a90b1db89bcb4b6a7671edca0f0 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* Remove Loader classChristian Kandeler2023-05-091-9/+9
| | | | | | | It was just an unnecessary indirection in the end. Change-Id: I956ed4858dcc2b528be1e1fce9ab24862b99ff62 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* Loader: Move out the setupProjectFilePath() methodChristian Kandeler2023-05-051-2/+1
| | | | | | | ... into SetupProjectParameters, where it belongs. Change-Id: I5cae2842200a053827739b947d1cd06e1bbe5ef9 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* Loader: Remove unnecessary search paths forwarding machineryChristian Kandeler2023-05-051-1/+0
| | | | | Change-Id: Ia4a8c144431c413701707c024185ca54f49b0829 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* Introduce loader/ subdirectoryChristian Kandeler2023-05-041-2/+2
| | | | | | | | Project loading functionality is implemented in various source files these days, so it makes sense to group them together. Change-Id: Iba42b0246c40610d2a03bf6cc7ed7d3bec9d5536 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* Rewrite ModuleLoaderChristian Kandeler2023-04-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | =================== Problem description =================== The ModuleLoader class as it exists before this patch has a number of serious problems: - It instantiates modules over and over again everywhere a Depends item appears. The different instances are later merged in a hopelessly obscure and error-prone way. - It seriously pollutes the module scopes so that sloppily written project files appear to work even though they shouldn't. - Dependencies between products are handled twice: Once using the normal module instantiation code (with the Export item acting like a Module item), and also with a parallel mechanism that does strange, seemingly redundant things especially regarding transitive dependencies, which appear to introduce enormous run-time overhead. It is also split up between ModuleLoader and ProjectResolver, adding even more confusion. - The code is messy, seriously under-documented and hardly understood even by its original authors. It presents a huge obstacle to potential contributors. ================= Patch description ================= - Each module is instantiated once per product. Property values are merged on the fly. Special handling for dependencies between products are kept to the absolutely required minimum. - There are no more extra passes for establishing inter-product dependencies. Instead, whenever an unhandled dependency is encountered, processing the current product is paused and resumed once the dependency is ready, with the product state getting saved and restored in between so no work is done twice. - The ModuleLoader class now really only locates and loads modules. The new main class is called ProjectTreeBuilder, and we have split off small, self-contained pieces wherever possible. This process will be continued in follow-up patches (see next section). ======= Outlook ======= The ProjectTreeBuilder ist still too large and should be split up further into small, easily digestible parts with clear responsibilities, until the top-level code becomes tidy and self-documenting. In the end, it can probably be merged with ProjectResolver and Loader. However, this first requires the tight coupling between ProjectTreeBuilder/ModuleProviderLoader/ProbesResolver/ProjectResolver to be broken; otherwise we can't produce clean interfaces. As this would involve touching a lot of otherwise unrelated code, it is out of scope for this patch. ================= Benchmarking data ================= We first present wall-time clock results gathered by running "qbs resolve --log-time" for qbs itself and Qt Creator on macOS and Windows. The numbers are the average of several runs, with outliers removed. Then the same for a simple QML project using a static Qt on Linux (this case is special because our current way of handling plugins causes a huge amount of modules to be loaded). Finally, we show the output of the qbs_benchmarker tool for resolving qbs and Qt Creator on Linux. The data shows a speed-up that is hardly noticeable for simple projects, but increases sharply with project complexity. This suggests that our new way of resolving does not suffer anymore from the non-linear slowdown when the number of dependencies gets large. Resolving qbs on Windows: Before this patch: ModuleLoader 3.6s, ProjectResolver 870ms With this patch: ProjectTreeBuilder 3.6s, ProjectResolver 840ms Resolving Qt Creator on Windows: Before this patch: ModuleLoader 17s, ProjectResolver 6.8s With this patch: ProjectTreeBuilder 10.0s, ProjectResolver 6.5s Resolving qbs on macOS: Before this patch: ModuleLoader 4.0s, ProjectResolver 2.3s With this patch: ProjectTreeBuilder 4.0s, ProjectResolver 2.3s Resolving Qt Creator on macOS: Before this patch: ModuleLoader 32.0s, ProjectResolver 15.6s With this patch: ProjectTreeBuilder 23.0s, ProjectResolver 15.3s Note that the above numbers are for an initial resolve, so they include the time for running Probes. The speed-up for re-resolving (with cached Probes) is even higher, in particular on macOS, where Probes take excessively long. Resolving with static Qt on Linux (QBS-1521): Before this patch: ModuleLoader 36s, ProjectResolver 18s With this patch: ProjectTreeBuilder 1.5s, ProjectResolver 14s Output of qbs_benchmarker for resolving qbs on Linux: Old instruction count: 10029744668 New instruction count: 9079802661 Relative change: -10 % Old peak memory usage: 69881840 Bytes New peak memory usage: 82434624 Bytes Relative change: +17 % Output of qbs_benchmarker for resolving Qt Creator on Linux: Old instruction count: 87364681688 New instruction count: 53634332869 Relative change: -39 % Old peak memory usage: 578458840 Bytes New peak memory usage: 567271960 Bytes Relative change: -2 % I don't know where the increased memory footprint for a small project comes from, but since it goes away for larger projects, it doesn't seem worth investigating. Fixes: QBS-1037 Task-number: QBS-1521 Change-Id: Ieeebce8a7ff68cdffc15d645e2342ece2426fa94 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com> Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Prevent dangling JS valuesChristian Kandeler2023-03-062-16/+5
| | | | | | | | | | | As opposed to QtScript, such values cannot be re-used in QuickJS. This was overlooked in 087c22e17721f37490dd2048a567b6a58065d939. I assume this is the culprit for seemingly random crashes and "not a function" messages we have been seeing sometimes when building with Qt Creator. Change-Id: Ia4e7aed0cda97439ac75db5ecfbf08ff096a02b2 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* Switch JavaScript back-endChristian Kandeler2023-02-0728-1047/+1064
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Newer clang versions seem to expose serious bugs in QtScript, whose complexity makes it difficult to track them down. We therefore switch to the more light-weight QuickJS, which offers all the features we need (most notably property access interception), as well as good performance. To save some porting effort, we removed the long-deprecated loadFile() and loadExtension() functions. During the porting procedure, we noticed and fixed thread safety issues in artifact access from JS commands. We consider this change important enough to bump the major version, so the next release will be 2.0. Detailed benchmarking data is below. In summary, we see a modest speed- up at the cost of a similarly modest increase in memory consumption (with the exception of project resolving on macOS, which has become a bit slower). Importantly, the increase does not rise with project size, as the comparison of qbs vs Qt Creator shows. Output of qbs_benchmarker on Linux with qbs as test project: ========== Performance data for Resolving ========== Old instruction count: 12870602895 New instruction count: 11923459780 Relative change: -8 % Old peak memory usage: 61775848 Bytes New peak memory usage: 67583424 Bytes Relative change: +9 % ========== Performance data for Rule Execution ========== Old instruction count: 4074062223 New instruction count: 3887473574 Relative change: -5 % Old peak memory usage: 35123704 Bytes New peak memory usage: 38398392 Bytes Relative change: +9 % ========== Performance data for Null Build ========== Old instruction count: 1104417596 New instruction count: 1011033948 Relative change: -9 % Old peak memory usage: 24461824 Bytes New peak memory usage: 25325920 Bytes Relative change: +3 % Output of qbs_benchmarker on Linux with Qt Creator as test project: ========== Performance data for Resolving ========== Old instruction count: 67166450352 New instruction count: 60772791018 Relative change: -10 % Old peak memory usage: 327011616 Bytes New peak memory usage: 343724176 Bytes Relative change: +5 % ========== Performance data for Rule Execution ========== Old instruction count: 71684351183 New instruction count: 67051936965 Relative change: -7 % Old peak memory usage: 374913688 Bytes New peak memory usage: 387790992 Bytes Relative change: +3 % ========== Performance data for Null Build ========== Old instruction count: 8383156078 New instruction count: 7930705668 Relative change: -6 % Old peak memory usage: 180468360 Bytes New peak memory usage: 182490384 Bytes Relative change: +1 % Real-world data building Qt Creator (using qbs --log-time, several runs, removing outliers): macOS: Resolving: 43s -> 47s Rule execution: 17s -> 14s Windows: Resolving: 18s -> 16s Rule execution: 22s -> 17s Fixes: QBS-913 Fixes: QBS-1103 Fixes: QBS-1126 Fixes: QBS-1227 Fixes: QBS-1684 Change-Id: Ie5088155026e85bbd1e303f1c67addb15810a3cb Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com> Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* RIP QMake buildIvan Komissarov2022-12-161-89/+0
| | | | | | | | | | We have been supported CMake build for quite some time so users should have plenty of time to adapt. Ubuntu, Brew and macports also use CMake for building QBS. Change-Id: Ib78177f4a7ca8cdea1a2f3a8eac8bfe804674f32 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Fix possible crash in ExecutorChristian Kandeler2022-10-141-2/+4
| | | | | | | Amends d8d7beb866b24793d9c04b6996276a4a8959bfa2. Change-Id: I6eefff5640ad1213e2ae36d7f71ba476ea4d475b Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* clang-tidy: fix 'performance-no-automatic-move' warningIvan Komissarov2022-08-161-1/+1
| | | | | Change-Id: I0fea777445be769080b5e5534eb8dd05cf4652be Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* clang-tidy: fix bugprone-branch-clone in executor.cppIvan Komissarov2022-08-151-4/+2
| | | | | Change-Id: I3ca9909c4a9061132c245985c4fd738fb7bc3009 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Merge remote-tracking branch 'origin/1.21' into 1.22Christian Kandeler2022-04-071-1/+0
|\ | | | | | | | | | | | | It seems we completely forgot to merge 1.21 into master, losing at least some of the bugfixes in 1.21.1. Change-Id: I4e8e32a861da817d9b686991933d6a32332534c5
| * Remove bogus reset of build graph's "dirty" flagChristian Kandeler2022-01-131-1/+0
| | | | | | | | | | | | | | | | It's unclear why that code was ever there. Fixes: QBS-1686 Change-Id: I893216c9b27afeec8913f59e55f475d58964eb92 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* | Use std::transform where it is possibleDenis Shienkov2022-01-273-13/+10
| | | | | | | | | | | | | | ... to unify and simplify a code. Change-Id: Ia493c5f428c1da4df3c8623e448be8ac72fd4f44 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Replace std::erase && std::remove_if chains with Internal::remove_ifDenis Shienkov2021-12-221-1/+3
| | | | | | | | | | Change-Id: Ia267b9419227db5f4382a33aa99eb7dbe0ada45f Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* | Replace missing std::all_of with Internal::all_ofDenis Shienkov2021-12-021-2/+1
| | | | | | | | | | Change-Id: I11dc7ce71c7ce7f161d75e3fcd2fc34c87e7733e Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Replace missing std::any_of with Internal::any_ofDenis Shienkov2021-12-023-10/+9
| | | | | | | | | | Change-Id: Ic17ce136f1438dbdc4cf1d5c88947d004748fd70 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Add missing std:: namespace for all functions from <cstdio> libraryDenis Shienkov2021-12-011-4/+4
| | | | | | | | | | Change-Id: Ia5c14b86e5e0952dbebf103c5355f49e41158cba Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Fix Clang-Tidy & Clazy 'readability-use-anyofallof' warningsDenis Shienkov2021-11-293-18/+13
| | | | | | | | | | Change-Id: I785b2c065dbd3daf4ae74f1e7a39e6be61489467 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Get rid of forever in favor to for(;;)Denis Shienkov2021-11-292-2/+2
| | | | | | | | | | Change-Id: I63255548d9191831324a84dfce9e9296585dba9b Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Fix Clang-Tidy & Clazy 'clazy-unused-non-trivial-variable' warningsDenis Shienkov2021-11-171-1/+0
| | | | | | | | | | Change-Id: Ie62da8d2a47fe9218d2246216e9affb5fe79374f Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Fix Clang-Tidy & Clazy 'clazy-incorrect-emit' warningsDenis Shienkov2021-11-161-1/+1
| | | | | | | | | | Change-Id: Ie424e43f328b6a5954efc8dfff3674c95e637600 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Fix Clang-Tidy & Clazy 'clazy-overloaded-signal' warningsDenis Shienkov2021-11-161-1/+1
| | | | | | | | | | | | | | | | This patch fixes the "signal error is overloaded [clazy-overloaded-signal]" warnings. Change-Id: Ibf822da6eb34c781696ea5e0839afd8cc408af74 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* | Fix Clang-Tidy & Clazy 'clazy-qstring-arg' warningsDenis Shienkov2021-11-151-2/+2
| | | | | | | | | | | | | | | | This patch fixes the "Use multi-arg instead [clazy-qstring-arg]" warnings. Change-Id: I205c94d33574b6f7af486b3654dd2d8591746f6c Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* | Use unique_ptr for managing ScriptEnginesIvan Komissarov2021-10-233-9/+6
|/ | | | | Change-Id: I89f510619196cc01a9e3b0c2273888b12b188928 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Get rid of Set::to/from methodsIvan Komissarov2021-08-165-6/+5
| | | | | | | | | ... and replace them with the new template rangeTo method Also, add efficient Set(Iter, Iter) ctor. Change-Id: I5a2345ca84373692e3ba815e5a8f38cb4cfc4308 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Wrap ModuleProviderInfoList in a structIvan Komissarov2021-07-271-2/+2
| | | | | | | Required for ongoing patchsets - later patches will add more members. Change-Id: Iad57e17139b104e55221059eedb8c0f057f6f4e0 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Give more details on a property values mismatchChristian Kandeler2021-07-221-2/+17
| | | | | | | | The user might not remember which properties were originally passed on the command line, so show them if they don't match the new ones. Change-Id: I41fbfc84832c0bf56a950a6b546bccca50c88564 Reviewed-by: Ivan Komissarov <ABBAPOH@gmail.com>
* qt6: Do not use QVariant::Type as it was deprecatedIvan Komissarov2021-02-111-1/+1
| | | | | Change-Id: I0dad1ee403176a665e4e9dead2f94dd032e1d75b Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* qt6: Do not use QVariant::type()Ivan Komissarov2021-02-112-2/+2
| | | | | | | | | ...and use QVariant::userType() instead since type() method was deprecated (variant.metaType().id() or variant.typeId() or variant.userType() should be user instead). Change-Id: I00b93c5e010a0c7b733b3c6dfeae2d744be32ce1 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* buildgraph: fix storing container sizesIvan Komissarov2021-02-101-1/+1
| | | | | | | | The type should match the one used in load() since in qt6 the type is not int anymore Change-Id: I0e7e402dec6f059279de933d5afd0c450cde8ddd Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* qt6: explicitly register Transformer * and JavaScriptCommand * metatypesIvan Komissarov2021-02-101-0/+3
| | | | | | | Otherwise, Qt complains when emitting the signal Change-Id: I1840eff8c041ca21475658cb3113e81298b3a8a6 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* qt6: replace some QStringRefs with QStringViewsIvan Komissarov2020-11-091-2/+2
| | | | | | | | | QStringRef does not exist anymore. Qml parser is not ported yet. Change-Id: Ifb99a529b69c0085363031e852ffd7576f1d93be Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Get rid of goto in InputArtifactScanner::resolveScanResultDependenciesIvan Komissarov2020-10-261-10/+17
| | | | | Change-Id: I9220b1e6344e90401abf4fb91115e77a3a6c996f Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Use make_shared in InputArtifactScanner::scannersForArtifactIvan Komissarov2020-10-261-4/+3
| | | | | Change-Id: Ia38f08fb32b50761e7fb8642019aad39a25c1ef2 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>