[sysui] replace onFoo handlers for Connections

- Connections { target: someTarget; onFoo: {} } is now deprecated
and warning is generated. onFoo should be changed to
'function onFoo(params)'

Fixes: AUTOSUITE-1597
Change-Id: I87d93939fa821c53bdf26478baa5444387b1b20e
Reviewed-by: Grigorii Zimin <gzimin@luxoft.com>

20 files changed, 42 insertions, 32 deletions

diff --git a/apps/com.luxoft.vehicle/panels/Vehicle3DPanel.qml b/apps/com.luxoft.vehicle/panels/Vehicle3DPanel.qml
index 56767e24..75a35460 100644
--- a/apps/com.luxoft.vehicle/panels/Vehicle3DPanel.qml
+++ b/apps/com.luxoft.vehicle/panels/Vehicle3DPanel.qml
@@ -147,7 +147,7 @@ Item {
                 target: frameCounter
                 enabled: !root.readyToChanges
                 property int fc: 0
-                onTriggered: {
+                function onTriggered() {
                     if (++fc == 3) {
                         root.readyToChanges = true;
                     }
diff --git a/apps/com.luxoft.vehicle/panels/Vehicle3DStudioPanel.qml b/apps/com.luxoft.vehicle/panels/Vehicle3DStudioPanel.qml
index 2c31b81e..32a0704b 100644
--- a/apps/com.luxoft.vehicle/panels/Vehicle3DStudioPanel.qml
+++ b/apps/com.luxoft.vehicle/panels/Vehicle3DStudioPanel.qml
@@ -120,7 +120,7 @@ Item {
         id: readyToChangeConnection
         target: studio3D
         property int fc: 0
-        onFrameUpdate: {
+        function onFrameUpdate() {
             fc += 1;
             // skip first 10 frames to be sure that all content is ready
             if (fc > 10) {
diff --git a/apps/com.luxoft.vehicle/views/VehicleView.qml b/apps/com.luxoft.vehicle/views/VehicleView.qml
index 5da1d8a5..644bd2ba 100644
--- a/apps/com.luxoft.vehicle/views/VehicleView.qml
+++ b/apps/com.luxoft.vehicle/views/VehicleView.qml
@@ -99,7 +99,9 @@ Item {
 
         Connections {
             target: vehicle3DPanelLoader.item
-            onLastCameraAngleChanged: root.store.cameraAngleView = target.lastCameraAngle
+            function onLastCameraAngleChanged() {
+                root.store.cameraAngleView = target.lastCameraAngle;
+            }
         }
 
         VehicleProxyPanel {
diff --git a/apps/com.pelagicore.apps.settings/views/SettingsView.qml b/apps/com.pelagicore.apps.settings/views/SettingsView.qml
index c4605b3b..c19f44fa 100644
--- a/apps/com.pelagicore.apps.settings/views/SettingsView.qml
+++ b/apps/com.pelagicore.apps.settings/views/SettingsView.qml
@@ -172,7 +172,7 @@ Control {
 
             Connections {
                 target: wifi
-                onCredentialsRequested: {
+                function onCredentialsRequested(ssid) {
                     wifiPopup.ssid = ssid;
                     wifiPopup.width = Qt.binding(() => wifiPanel.wifiPopupWidth);
                     wifiPopup.height = Qt.binding(() => wifiPanel.wifiPopupHeight);
diff --git a/apps/com.pelagicore.calendar/panels/+lucee/CalendarWidgetPanel.qml b/apps/com.pelagicore.calendar/panels/+lucee/CalendarWidgetPanel.qml
index aa8839c6..cb7f351c 100644
--- a/apps/com.pelagicore.calendar/panels/+lucee/CalendarWidgetPanel.qml
+++ b/apps/com.pelagicore.calendar/panels/+lucee/CalendarWidgetPanel.qml
@@ -152,7 +152,7 @@ Item {
 
                     Connections {
                         target: root
-                        onDateClicked: {
+                        function onDateClicked() {
                             weatherIcon.randomIndex = Math.floor((Math.random() * (3)) + 0);
                         }
                     }
diff --git a/apps/com.pelagicore.calendar/panels/CalendarMaximizedPanel.qml b/apps/com.pelagicore.calendar/panels/CalendarMaximizedPanel.qml
index 5cb2d2d8..6eee833c 100644
--- a/apps/com.pelagicore.calendar/panels/CalendarMaximizedPanel.qml
+++ b/apps/com.pelagicore.calendar/panels/CalendarMaximizedPanel.qml
@@ -219,14 +219,16 @@ Item {
             Repeater {
                 model: 4
                 Image {
+                    id: weatherIcon
+
                     width: Sizes.dp(80)
                     height: Sizes.dp(80)
                     fillMode: Image.PreserveAspectFit
 
                     Connections {
                         target: root
-                        onDateClicked: {
-                            randomIndex = Math.floor((Math.random() * (3)) + 0);
+                        function onDateClicked() {
+                            weatherIcon.randomIndex = Math.floor((Math.random() * (3)) + 0);
                         }
                     }
 
@@ -255,12 +257,14 @@ Item {
             delegatedItemWidth: eventList.width
             interactive: false
             delegate: EventListItem {
+                id: item
+
                 property int randomIndex: Math.floor((Math.random() * (8)) + 0)
 
                 Connections {
                     target: root
-                    onDateClicked: {
-                        randomIndex = Math.floor((Math.random() * (8)) + 0);
+                    function onDateClicked() {
+                        item.randomIndex = Math.floor((Math.random() * (8)) + 0);
                     }
                 }
 
diff --git a/apps/com.pelagicore.climate/controls/TemperatureSlider.qml b/apps/com.pelagicore.climate/controls/TemperatureSlider.qml
index d1da8c8b..a92303ca 100644
--- a/apps/com.pelagicore.climate/controls/TemperatureSlider.qml
+++ b/apps/com.pelagicore.climate/controls/TemperatureSlider.qml
@@ -45,8 +45,8 @@ Slider {
 
     Connections {
         target: root
-        onPressedChanged: {
-            if (!pressed)
+        function onPressedChanged() {
+            if (!root.pressed)
                 root.sliderReleased()
         }
     }
diff --git a/apps/com.pelagicore.climate/panels/ClimateContentPanel.qml b/apps/com.pelagicore.climate/panels/ClimateContentPanel.qml
index 506348fa..e7ab2def 100644
--- a/apps/com.pelagicore.climate/panels/ClimateContentPanel.qml
+++ b/apps/com.pelagicore.climate/panels/ClimateContentPanel.qml
@@ -147,7 +147,7 @@ Item {
 
     Connections {
         target: root.store ? root.store.leftSeat : null
-        onValueChanged: {
+        function onValueChanged() {
             if (!leftTempSlider.pressed) {
                 leftTempSlider.value = target.value
             }
@@ -171,7 +171,7 @@ Item {
 
     Connections {
         target: root.store ? root.store.rightSeat : null
-        onValueChanged: {
+        function onValueChanged() {
             if (!rightTempSlider.pressed) {
                 rightTempSlider.value = target.value
             }
diff --git a/apps/com.pelagicore.climate/stores/ClimateStore.qml b/apps/com.pelagicore.climate/stores/ClimateStore.qml
index 0a192006..7948a391 100644
--- a/apps/com.pelagicore.climate/stores/ClimateStore.qml
+++ b/apps/com.pelagicore.climate/stores/ClimateStore.qml
@@ -195,7 +195,7 @@ QtObject {
 
         property var conns: Connections {
             target: climateControl
-            onAirflowDirectionsChanged: airflow.updateProperties()
+            function onAirflowDirectionsChanged() { airflow.updateProperties() }
         }
 
         function updateProperties() {
diff --git a/apps/com.pelagicore.downloads/controls/DownloadAppList.qml b/apps/com.pelagicore.downloads/controls/DownloadAppList.qml
index f082f3e5..6a0ea71c 100644
--- a/apps/com.pelagicore.downloads/controls/DownloadAppList.qml
+++ b/apps/com.pelagicore.downloads/controls/DownloadAppList.qml
@@ -99,7 +99,9 @@ ListView {
 
         Connections {
             target: d
-            onInstalledPackagesChanged: {
+            function onInstalledPackagesChanged(isPackageInstalledByPackageControllerFunc,
+                                                isPackageBuiltInFunc,
+                                                getInstalledPackageSizeTextFunc) {
                 // functions are passed as parameters to signal
                 model.isInstalled = isPackageInstalledByPackageControllerFunc(model.id);
                 if (isInstalled) {
diff --git a/apps/com.pelagicore.downloads/stores/DownloadsStates.qml b/apps/com.pelagicore.downloads/stores/DownloadsStates.qml
index 7c9d96ae..6b558aab 100644
--- a/apps/com.pelagicore.downloads/stores/DownloadsStates.qml
+++ b/apps/com.pelagicore.downloads/stores/DownloadsStates.qml
@@ -184,7 +184,7 @@ DSM.StateMachine {
 
                 Connections {
                     target: appStoreConfig
-                    onLoginFailed: {
+                    function onLoginFailed() {
                         connectedErrorState.errorText = qsTr("Login Failed");
                     }
                 }
@@ -223,7 +223,7 @@ DSM.StateMachine {
 
                     Connections {
                         target: jsonCategoryModel
-                        onStatusChanged: {
+                        function onStatusChanged() {
                             if (jsonCategoryModel.status === "error")
                                 connectedErrorState.errorText = qsTr("Fetching categories error");
                         }
@@ -277,7 +277,7 @@ DSM.StateMachine {
 
                     Connections {
                         target: jsonAppModel
-                        onStatusChanged: {
+                        function onStatusChanged() {
                             if (jsonAppModel.status === "error")
                                 connectedErrorState.errorText = qsTr("Fetching apps error");
                         }
diff --git a/apps/com.pelagicore.downloads/stores/DownloadsStore.qml b/apps/com.pelagicore.downloads/stores/DownloadsStore.qml
index ee9ab822..b73880aa 100644
--- a/apps/com.pelagicore.downloads/stores/DownloadsStore.qml
+++ b/apps/com.pelagicore.downloads/stores/DownloadsStore.qml
@@ -203,8 +203,10 @@ Item {
     Connections {
         target: PackageManager
 
-        onTaskProgressChanged: root.currentInstallationProgress = progress
-        onTaskFailed: {
+        function onTaskProgressChanged(taskId, progress) {
+            root.currentInstallationProgress = progress
+        }
+        function onTaskFailed(taskId) {
             var packageId = PackageManager.taskPackageId(taskId);
             var icon = PackageManager.package("com.pelagicore.downloads").icon;
             var pkg = null;
@@ -230,7 +232,7 @@ Item {
 
             currentInstallationProgress = 0.0;
         }
-        onTaskFinished: {
+        function onTaskFinished(taskId) {
             var packageId = PackageManager.taskPackageId(taskId);
             var icon = PackageManager.package("com.pelagicore.downloads").icon;
             var pkg = null;
diff --git a/apps/com.pelagicore.downloads/views/DownloadsView.qml b/apps/com.pelagicore.downloads/views/DownloadsView.qml
index 212ecf48..6de543eb 100644
--- a/apps/com.pelagicore.downloads/views/DownloadsView.qml
+++ b/apps/com.pelagicore.downloads/views/DownloadsView.qml
@@ -215,7 +215,7 @@ Item {
 
             Connections {
                 target: root.store
-                onInstalledPackagesChanged: {
+                function onInstalledPackagesChanged() {
                     // update states of app items, pass functions to update function
                     appList.refreshAppsInfo(root.store.isPackageInstalledByPackageController,
                                             root.store.isPackageBuiltIn,
@@ -333,7 +333,7 @@ Item {
 
                 Connections {
                     target: root
-                    onStateChanged: { updateStatesList(); }
+                    function onStateChanged() { updateStatesList(); }
                 }
             }
 
diff --git a/apps/com.pelagicore.map/Main.qml b/apps/com.pelagicore.map/Main.qml
index d202d2de..830ab006 100644
--- a/apps/com.pelagicore.map/Main.qml
+++ b/apps/com.pelagicore.map/Main.qml
@@ -167,7 +167,7 @@ QtObject {
 
                     Connections {
                         target: mainMap.store
-                        onNavigationDemoActiveChanged: {
+                        function onNavigationDemoActiveChanged() {
                             if (mainMap.store.navigationDemoActive) {
                                 icMapView.path = mainMap.store.routeModel.get(0).path;
                                 icMapView.state = "demo_driving";
diff --git a/apps/com.pelagicore.map/views/MapView.qml b/apps/com.pelagicore.map/views/MapView.qml
index 87790d03..2fee8c35 100644
--- a/apps/com.pelagicore.map/views/MapView.qml
+++ b/apps/com.pelagicore.map/views/MapView.qml
@@ -81,7 +81,7 @@ Item {
     Connections {
         target: root.store
 
-        onRequestNavigationReceived: {
+        function onRequestNavigationReceived(address, coord, boundingBox) {
             root.maximizeMap();
             root.store.navigationDemoActive = false;
             mapBoxPanel.state = "initial";
@@ -96,7 +96,7 @@ Item {
             mapBoxPanel.state = "destination_selection";
         }
 
-        onRequestRaiseAppReceived: { root.maximizeMap(); }
+        function onRequestRaiseAppReceived() { root.maximizeMap(); }
     }
 
     MapBoxPanel {
diff --git a/apps/com.pelagicore.music/stores/MusicStore.qml b/apps/com.pelagicore.music/stores/MusicStore.qml
index 1054fd4a..a69ef5e3 100644
--- a/apps/com.pelagicore.music/stores/MusicStore.qml
+++ b/apps/com.pelagicore.music/stores/MusicStore.qml
@@ -145,7 +145,7 @@ Store {
     property Connections con: Connections {
         target: player.playQueue
 
-        onRowsInserted: {
+        function onRowsInserted(parentIndex, first, last) {
             console.log(Logging.apps, "Music Queue / Playlist Row Inserted: ", first);
             player.playQueue.currentIndex = first;
         }
diff --git a/apps/com.pelagicore.music/views/+lucee/MusicView.qml b/apps/com.pelagicore.music/views/+lucee/MusicView.qml
index 7696afaf..9362682f 100644
--- a/apps/com.pelagicore.music/views/+lucee/MusicView.qml
+++ b/apps/com.pelagicore.music/views/+lucee/MusicView.qml
@@ -100,7 +100,7 @@ Item {
         onNextClicked: root.store.nextSong()
         Connections {
             target: store
-            onSongModelPopulated: { artAndTitlesBlock.populateModel(); }
+            function onSongModelPopulated() { artAndTitlesBlock.populateModel(); }
         }
     }
 
diff --git a/apps/com.pelagicore.music/views/+lucee/WidgetContentView.qml b/apps/com.pelagicore.music/views/+lucee/WidgetContentView.qml
index c4032628..cd824bb9 100644
--- a/apps/com.pelagicore.music/views/+lucee/WidgetContentView.qml
+++ b/apps/com.pelagicore.music/views/+lucee/WidgetContentView.qml
@@ -71,7 +71,7 @@ Item {
         onNextClicked: store.nextSong()
         Connections {
             target: store
-            onSongModelPopulated: { artAndTitlesBlock.populateModel(); }
+            function onSongModelPopulated() { artAndTitlesBlock.populateModel(); }
         }
     }
 
diff --git a/apps/com.pelagicore.music/views/WidgetContentView.qml b/apps/com.pelagicore.music/views/WidgetContentView.qml
index 75b7f77b..c1ab5c80 100644
--- a/apps/com.pelagicore.music/views/WidgetContentView.qml
+++ b/apps/com.pelagicore.music/views/WidgetContentView.qml
@@ -119,7 +119,7 @@ Item {
         onNextClicked: root.store.nextSong()
         Connections {
             target: root.store
-            onSongModelPopulated: { artAndTitlesBlock.populateModel(); }
+            function onSongModelPopulated() { artAndTitlesBlock.populateModel(); }
         }
     }
 
diff --git a/apps/com.theqtcompany.cluster/panels/GaugesPanel3D.qml b/apps/com.theqtcompany.cluster/panels/GaugesPanel3D.qml
index fef9b7c7..849a64c2 100644
--- a/apps/com.theqtcompany.cluster/panels/GaugesPanel3D.qml
+++ b/apps/com.theqtcompany.cluster/panels/GaugesPanel3D.qml
@@ -194,13 +194,13 @@ Item {
 
             Connections {
                 target: root
-                onLightThemeVisibleChanged: {
+                function onLightThemeVisibleChanged() {
                     if (!changeGaugesMainColorAnimation.running && !changeThemeAnimation.running) {
                         changeThemeAnimation.start()
                     }
                 }
 
-                onGaugesMainColorChanged: {
+                function onGaugesMainColorChanged() {
                     if (!changeGaugesMainColorAnimation.running && !changeThemeAnimation.running) {
                         changeGaugesMainColorAnimation.start();
                     }