diff options
author | Denis Mingulov <denis@mingulov.com> | 2012-01-27 15:25:15 +0200 |
---|---|---|
committer | Leandro Melo <leandro.melo@nokia.com> | 2012-01-30 14:06:23 +0100 |
commit | 142cee902bf7f0e6ed130eb62069902c8cb9b961 (patch) | |
tree | ab26782f9dc0c5bb1f83566e3b92f8584a652718 | |
parent | e99e435818eaa13cbe95b6429a4615ae5416ac60 (diff) |
TextEditor: Fix incorrect dependency to CppEditor resources
TextEditor BaseHoverHandler::addF1ToToolTip() method has used
a resource from CppEditor (:/cppeditor/images/f1.png), despite
of the inverse official dependecy in PluginSpec file and other
classes.
As it is not used anywhere else - to fix the issue f1.png and
f1.svg are moved from CppEditor to TextEditor.
Change-Id: I14b542837d6337bd08e19ad72cf4a869be08465a
Reviewed-by: Christian Stenger <christian.stenger@nokia.com>
Reviewed-by: Leandro Melo <leandro.melo@nokia.com>
-rw-r--r-- | src/plugins/cppeditor/cppeditor.qrc | 1 | ||||
-rw-r--r-- | src/plugins/texteditor/basehoverhandler.cpp | 2 | ||||
-rw-r--r-- | src/plugins/texteditor/images/f1.png (renamed from src/plugins/cppeditor/images/f1.png) | bin | 677 -> 677 bytes | |||
-rw-r--r-- | src/plugins/texteditor/images/f1.svg (renamed from src/plugins/cppeditor/images/f1.svg) | 0 | ||||
-rw-r--r-- | src/plugins/texteditor/texteditor.qrc | 1 | ||||
-rw-r--r-- | tests/system/suite_qtquick/tst_qml_editor/test.py | 12 |
6 files changed, 8 insertions, 8 deletions
diff --git a/src/plugins/cppeditor/cppeditor.qrc b/src/plugins/cppeditor/cppeditor.qrc index 61cf4a08a6..6e5f83fba6 100644 --- a/src/plugins/cppeditor/cppeditor.qrc +++ b/src/plugins/cppeditor/cppeditor.qrc @@ -4,6 +4,5 @@ <file>images/qt_h.png</file> <file>CppEditor.mimetypes.xml</file> <file>images/qt_c.png</file> - <file>images/f1.png</file> </qresource> </RCC> diff --git a/src/plugins/texteditor/basehoverhandler.cpp b/src/plugins/texteditor/basehoverhandler.cpp index 93821eb92f..e2f6badd46 100644 --- a/src/plugins/texteditor/basehoverhandler.cpp +++ b/src/plugins/texteditor/basehoverhandler.cpp @@ -113,7 +113,7 @@ void BaseHoverHandler::appendToolTip(const QString &extension) void BaseHoverHandler::addF1ToToolTip() { m_toolTip = QString(QLatin1String("<table><tr><td valign=middle>%1</td><td> " - "<img src=\":/cppeditor/images/f1.png\"></td>" + "<img src=\":/texteditor/images/f1.png\"></td>" "</tr></table>")).arg(m_toolTip); } diff --git a/src/plugins/cppeditor/images/f1.png b/src/plugins/texteditor/images/f1.png Binary files differindex 1f3dd0be93..1f3dd0be93 100644 --- a/src/plugins/cppeditor/images/f1.png +++ b/src/plugins/texteditor/images/f1.png diff --git a/src/plugins/cppeditor/images/f1.svg b/src/plugins/texteditor/images/f1.svg index 468594cb77..468594cb77 100644 --- a/src/plugins/cppeditor/images/f1.svg +++ b/src/plugins/texteditor/images/f1.svg diff --git a/src/plugins/texteditor/texteditor.qrc b/src/plugins/texteditor/texteditor.qrc index 86fa6638cb..49b0b46325 100644 --- a/src/plugins/texteditor/texteditor.qrc +++ b/src/plugins/texteditor/texteditor.qrc @@ -5,5 +5,6 @@ <file>TextEditor.mimetypes.xml</file> <file>images/refactormarker.png</file> <file>images/snippet.png</file> + <file>images/f1.png</file> </qresource> </RCC> diff --git a/tests/system/suite_qtquick/tst_qml_editor/test.py b/tests/system/suite_qtquick/tst_qml_editor/test.py index f4cf3a46c3..624705285f 100644 --- a/tests/system/suite_qtquick/tst_qml_editor/test.py +++ b/tests/system/suite_qtquick/tst_qml_editor/test.py @@ -156,9 +156,9 @@ def testHovering(): expectedTypes = ["TextTip", "TextTip"] expectedValues = [ {'text':'<table><tr><td valign=middle>FocusScope\n<p>The FocusScope object explicitly ' - 'creates a focus scope.</p></td><td> <img src=":/cppeditor/images/f1.png"></td></tr></table>'}, + 'creates a focus scope.</p></td><td> <img src=":/texteditor/images/f1.png"></td></tr></table>'}, {'text':'<table><tr><td valign=middle>Rectangle\n<p>The Rectangle item provides a filled rectangle with an ' - 'optional border.</p></td><td> <img src=":/cppeditor/images/f1.png"></td></tr></table>'} + 'optional border.</p></td><td> <img src=":/texteditor/images/f1.png"></td></tr></table>'} ] alternativeValues = [{"text":"FocusScope"}, {"text":"Rectangle"}] verifyHoveringOnEditor(editor, lines, additionalKeyPresses, expectedTypes, expectedValues, alternativeValues) @@ -172,14 +172,14 @@ def testHovering(): {'text':'<table><tr><td valign=middle>boolean<p>This property indicates whether the item has focus ' 'within the enclosing focus scope. If true, this item will gain active focus when the enclosing ' 'focus scope gains active focus. In the following example, <tt>input</tt> will be given active focus ' - 'when <tt>scope</tt> gains active focus.</p></td><td> <img src=":/cppeditor/images/f1.png"' + 'when <tt>scope</tt> gains active focus.</p></td><td> <img src=":/texteditor/images/f1.png"' '></td></tr></table>'}, {'text':'<table><tr><td valign=middle>string<p>This property holds the color used to fill the rectangle.' - '</p></td><td> <img src=":/cppeditor/images/f1.png"></td></tr></table>'}, + '</p></td><td> <img src=":/texteditor/images/f1.png"></td></tr></table>'}, {'text':'<table><tr><td valign=middle>State<p>This property holds a list of states defined by the item.' - '</p></td><td> <img src=":/cppeditor/images/f1.png"></td></tr></table>'}, + '</p></td><td> <img src=":/texteditor/images/f1.png"></td></tr></table>'}, {'text':'<table><tr><td valign=middle>Transition<p>This property holds a list of transitions defined by ' - 'the item.</p></td><td> <img src=":/cppeditor/images/f1.png"></td></tr></table>'} + 'the item.</p></td><td> <img src=":/texteditor/images/f1.png"></td></tr></table>'} ] alternativeValues = [{"text":"boolean"}, {"text":"string"}, {"text":"State"}, {"text":"Transition"}] verifyHoveringOnEditor(editor, lines, additionalKeyPresses, expectedTypes, expectedValues, alternativeValues) |