aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Stenger <christian.stenger@qt.io>2024-05-16 15:31:37 +0200
committerChristian Stenger <christian.stenger@qt.io>2024-05-21 05:34:34 +0000
commit85617f1369e2638d47c1b583650200bd4805ddb3 (patch)
treed81c043cad65059e6ddd7467f5042ad9d86a55a7
parente48a40bd8dd029cbea797a4dc4a1ccae379218d7 (diff)
Git: Avoid crash when reloading files
Explicitly reset the document when the document gets closed. Task-number: QTCREATORBUG-30824 Change-Id: I4fb3d6fd6041990e5b8b4f6b7c4fd9ebc62f5a4a Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: André Hartmann <aha_1980@gmx.de>
-rw-r--r--src/plugins/git/instantblame.cpp7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/plugins/git/instantblame.cpp b/src/plugins/git/instantblame.cpp
index 5921518c34..f932c78698 100644
--- a/src/plugins/git/instantblame.cpp
+++ b/src/plugins/git/instantblame.cpp
@@ -166,6 +166,13 @@ void InstantBlame::setup()
connect(EditorManager::instance(), &EditorManager::currentEditorChanged,
this, setupBlameForEditor);
+ connect(EditorManager::instance(), &EditorManager::documentClosed,
+ this, [this](IDocument *doc) {
+ if (m_document != doc)
+ return;
+ disconnect(m_documentChangedConn);
+ m_document = nullptr;
+ });
}
// Porcelain format of git blame output