aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCristian Adam <cristian.adam@qt.io>2022-02-09 11:07:15 +0100
committerCristian Adam <cristian.adam@qt.io>2022-02-10 11:08:26 +0000
commita204ad3236396e82ad62ce9a2efbbd1f982f6480 (patch)
treeff0e4676f9ca34807d7200f51e472a2482f39e7a
parent14ee4654c1140a76c03af1d2350fd2c548efc43b (diff)
CMakePM: Do not reconfigure project on KitUpdated
Initial Configuration will get the updated kit values and it's up to the user to react. The reconfiguration doesn't help at all, since none of the variables / options ends up in the Current Configuration. Change-Id: I5ee75fce1a33ce30a011ce6f1b6399fd79727ca6 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Eike Ziller <eike.ziller@qt.io>
-rw-r--r--src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp11
1 files changed, 0 insertions, 11 deletions
diff --git a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
index 5817ace058..c4d2127573 100644
--- a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
@@ -805,17 +805,6 @@ void CMakeBuildSystem::wireUpConnections()
// At this point the entire project will be fully configured, so let's connect everything and
// trigger an initial parser run
- // Kit changed:
- connect(KitManager::instance(), &KitManager::kitUpdated, this, [this](Kit *k) {
- if (k != kit())
- return; // not for us...
- // FIXME: This is no longer correct: QtC now needs to update the initial parameters
- // FIXME: and then ask to reconfigure.
- qCDebug(cmakeBuildSystemLog) << "Requesting parse due to kit being updated";
- setParametersAndRequestParse(BuildDirParameters(cmakeBuildConfiguration()),
- CMakeBuildSystem::REPARSE_FORCE_CMAKE_RUN);
- });
-
// Became active/inactive:
connect(target(), &Target::activeBuildConfigurationChanged, this, [this]() {
// Build configuration has changed: