aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Hartmann <thomas.hartmann@qt.io>2022-10-19 16:03:22 +0200
committerThomas Hartmann <thomas.hartmann@qt.io>2022-10-20 08:19:15 +0000
commite2706436a902ea069ca537dde50a0ce0533d7ccc (patch)
treefb8cac4c546bbe2e85e171290f2eb27fa2b88f33
parentc23564c337dff6f44739de4537f7ff8538c4df21 (diff)
QmlDesigner: Fix Q_ASSERT
instanceForObject(item) will assert if the instance does not exist. We already do check if the instance is actually valid. Change-Id: I0b0ef37d7db3d1e4195504ee8e5f92243bb26d83 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
-rw-r--r--share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5nodeinstanceserver.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5nodeinstanceserver.cpp b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5nodeinstanceserver.cpp
index 462c1c7852..c7bf859daa 100644
--- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5nodeinstanceserver.cpp
+++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5nodeinstanceserver.cpp
@@ -400,7 +400,9 @@ QImage Qt5NodeInstanceServer::grabItem([[maybe_unused]] QQuickItem *item)
if (!isLayerEnabled(pItem))
pItem->refFromEffectItem(false);
- ServerNodeInstance instance = instanceForObject(item);
+ ServerNodeInstance instance;
+ if (hasInstanceForObject(item))
+ instance = instanceForObject(item);
const bool rootIs3DObject = rootIsRenderable3DObject();