diff options
| author | Cristian Adam <cristian.adam@qt.io> | 2023-08-09 13:48:24 +0200 |
|---|---|---|
| committer | Cristian Adam <cristian.adam@qt.io> | 2023-08-24 18:06:35 +0000 |
| commit | dd1c9d1b71861563abb3fd4be11dc0cc91223b99 (patch) | |
| tree | b0c1837c79d14f1419af1cf2ab381e8c1e2db9ea /src/app | |
| parent | f8005cced8d9940e8970ab755e91c6cba2364579 (diff) | |
App: Replace QtLockedFile usage with QLockFile
We had an import of QtLockedFile from 2008. On Windows we could see a
lot of QtLockedFile cycles for qtcreator.exe. The 2008 version was using
a semaphore.
I've tried the latest QtSolutions version from 2016, which was using
only mutexes. qtcreator.exe would still show up lots of cycles for
QtLockedFile.
Then switched to QLockFile (added in Qt 5.1), and I couldn't see any
more CPU usage!
Task-number: QTCREATORBUG-29416
Change-Id: Ibfd102f3e90de39c807ff1140e597b79a7b6ca8e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
(cherry picked from commit 1fca05959f0a321943d803941c2fcdb7f6f0258d)
Diffstat (limited to 'src/app')
| -rw-r--r-- | src/app/app.qbs | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/src/app/app.qbs b/src/app/app.qbs index 8bce23f642..5c293781c2 100644 --- a/src/app/app.qbs +++ b/src/app/app.qbs @@ -40,7 +40,6 @@ QtcProduct { : ["$ORIGIN/../" + qtc.libDirName + "/qtcreator"] cpp.includePaths: [ project.sharedSourcesDir + "/qtsingleapplication", - project.sharedSourcesDir + "/qtlockedfile", ] cpp.frameworks: base.concat(qbs.targetOS.contains("macos") ? ["Foundation"] : []) @@ -59,7 +58,6 @@ QtcProduct { "../shared/qtsingleapplication/qtsingleapplication.cpp", "../shared/qtsingleapplication/qtlocalpeer.h", "../shared/qtsingleapplication/qtlocalpeer.cpp", - "../shared/qtlockedfile/qtlockedfile.cpp", "../tools/qtcreatorcrashhandler/crashhandlersetup.cpp", "../tools/qtcreatorcrashhandler/crashhandlersetup.h" ] @@ -86,22 +84,6 @@ QtcProduct { } Group { - name: "QtLockedFile_unix" - condition: qbs.targetOS.contains("unix") - files: [ - "../shared/qtlockedfile/qtlockedfile_unix.cpp" - ] - } - - Group { - name: "QtLockedFile_win" - condition: qbs.targetOS.contains("windows") - files: [ - "../shared/qtlockedfile/qtlockedfile_win.cpp" - ] - } - - Group { name: "main_macos" condition: qbs.targetOS.contains("macos") files: [ |