diff options
author | hjk <hjk@qt.io> | 2020-04-29 09:50:12 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2020-04-29 09:13:10 +0000 |
commit | 26b409c610fad504f8e838dd05d6a8294d5debed (patch) | |
tree | d5ec1f239d1a92d1acd70b124783ac1f293affc8 /src/libs/modelinglib | |
parent | f6042b257d33a760cbb6bb80340c98271680c6b5 (diff) |
Modeling: Avoid undefined behavior
With vector based QStringList there's no sequence point between
decrement and assignment.
Drop the assignment, it's unneeded anyway.
Change-Id: Ib88008ec4e3ddada3807ca41fbcc0c981cef5fe3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/libs/modelinglib')
-rw-r--r-- | src/libs/modelinglib/qmt/controller/namecontroller.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libs/modelinglib/qmt/controller/namecontroller.cpp b/src/libs/modelinglib/qmt/controller/namecontroller.cpp index 25ebbc171f3..b336688f041 100644 --- a/src/libs/modelinglib/qmt/controller/namecontroller.cpp +++ b/src/libs/modelinglib/qmt/controller/namecontroller.cpp @@ -138,7 +138,7 @@ QStringList NameController::buildElementsPath(const QString &filePath, bool igno QStringList split = filePath.split("/"); QStringList::const_iterator splitEnd = split.constEnd(); if (ignoreLastFilePathPart || split.last().isEmpty()) - splitEnd = --splitEnd; + --splitEnd; for (auto it = split.constBegin(); it != splitEnd; ++it) { QString packageName = qmt::NameController::convertFileNameToElementName(*it); relativeElements.append(packageName); |