QmlJS: Stop doing significant work in constructors.

To avoid order-of-initialization problems.

Reviewed-by: Thomas Hartmann

1 files changed, 5 insertions, 4 deletions

diff --git a/src/libs/qmljs/qmljslink.h b/src/libs/qmljs/qmljslink.h
index 2fb421dda4..80809d4328 100644
--- a/src/libs/qmljs/qmljslink.h
+++ b/src/libs/qmljs/qmljslink.h
@@ -54,14 +54,15 @@ class QMLJS_EXPORT Link
     Q_DECLARE_TR_FUNCTIONS(QmlJS::Link)
 
 public:
-    // Link all documents in snapshot, collecting all diagnostic messages
     Link(Interpreter::Context *context, const Snapshot &snapshot,
-         const QStringList &importPaths, QHash<QString, QList<DiagnosticMessage> > *messages = 0);
+         const QStringList &importPaths);
+
+    // Link all documents in snapshot, collecting all diagnostic messages (if messages != 0)
+    void operator()(QHash<QString, QList<DiagnosticMessage> > *messages = 0);
 
     // Link all documents in snapshot, appending the diagnostic messages
     // for 'doc' in 'messages'
-    Link(Interpreter::Context *context, const Snapshot &snapshot,
-         const QStringList &importPaths, const Document::Ptr &doc, QList<DiagnosticMessage> *messages);
+    void operator()(const Document::Ptr &doc, QList<DiagnosticMessage> *messages);
 
     ~Link();