diff options
| author | Oswald Buddenhagen <oswald.buddenhagen@qt.io> | 2017-01-11 13:55:31 +0100 |
|---|---|---|
| committer | Robert Loehning <robert.loehning@qt.io> | 2017-01-12 17:55:24 +0000 |
| commit | ec50c146b3bff251d92e1bf106f23ac4e8a08e46 (patch) | |
| tree | ab4c1f506fe52de9f1af1e2551eabefaf9c8a4c9 /src/libs/utils/consoleprocess.h | |
| parent | 4b0016fb2a6d4d5875de2307090bed595f16cc0a (diff) | |
fix "Open Command Prompt Here" on windows with qt 5.8
qt 5.8 made QProcess::startDetached()'s behavior consistent with
start(), which means it won't open a console any more. however, qtc
relied on this (unspecified) behavior.
the correct solution is to add a static function startTerminalEmulator()
to ConsoleProcess, which already has most of the necessary code anyway.
Task-number: QTCREATORBUG-17439
Change-Id: Icf04666869ce6593555302a54c49331a29846a99
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Diffstat (limited to 'src/libs/utils/consoleprocess.h')
| -rw-r--r-- | src/libs/utils/consoleprocess.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/libs/utils/consoleprocess.h b/src/libs/utils/consoleprocess.h index 8a4e264de3a..6f081172583 100644 --- a/src/libs/utils/consoleprocess.h +++ b/src/libs/utils/consoleprocess.h @@ -91,6 +91,8 @@ public: static QString terminalEmulator(const QSettings *settings, bool nonEmpty = true); static void setTerminalEmulator(QSettings *settings, const QString &term); + static bool startTerminalEmulator(QSettings *settings, const QString &workingDir); + signals: void error(QProcess::ProcessError error); void processError(const QString &errorString); |