diff options
author | hjk <hjk@qt.io> | 2022-06-01 15:19:31 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2022-06-03 09:42:26 +0000 |
commit | d76458a8b6a03ba3b5657c88221884c05c848467 (patch) | |
tree | c001d7872e1d6191cc5c5256afc8961ff6cefde5 /src/libs/utils/qtcprocess.cpp | |
parent | b72f41c7f0dcd01e4d16aef8520bbc29bfb51233 (diff) |
Utils: Replace Environment::size() check by some isValid() function
More descriptive, and later implementable without full expansion.
Change-Id: Ic3b17ea0b07273f292827a7b63e7695b4bd1cf23
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/libs/utils/qtcprocess.cpp')
-rw-r--r-- | src/libs/utils/qtcprocess.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libs/utils/qtcprocess.cpp b/src/libs/utils/qtcprocess.cpp index c4910ddec0..10340eb0ef 100644 --- a/src/libs/utils/qtcprocess.cpp +++ b/src/libs/utils/qtcprocess.cpp @@ -611,7 +611,7 @@ public: Environment fullEnvironment() const { Environment env = m_setup.m_environment; - if (env.size() == 0) { + if (!env.isValid()) { // FIXME: Either switch to using EnvironmentChange instead of full Environments, or // feed the full environment into the QtcProcess instead of fixing it up here. // qWarning("QtcProcess::start: Empty environment set when running '%s'.", @@ -1113,7 +1113,7 @@ QString QtcProcess::toStandaloneCommandLine() const d->m_setup.m_workingDirectory.path(); } parts.append("-i"); - if (d->m_setup.m_environment.size() > 0) { + if (d->m_setup.m_environment.isValid()) { const QStringList envVars = d->m_setup.m_environment.toStringList(); std::transform(envVars.cbegin(), envVars.cend(), std::back_inserter(parts), ProcessArgs::quoteArgUnix); |