diff options
| author | Alessandro Portale <alessandro.portale@qt.io> | 2020-11-21 01:04:56 +0100 |
|---|---|---|
| committer | Alessandro Portale <alessandro.portale@qt.io> | 2020-11-27 09:16:08 +0000 |
| commit | 81f3452e1cf8cc7788ace0e920a75cded52c0ae7 (patch) | |
| tree | 85db4b9a8d64544b7a8a15ec3911ee96e82b1e5d /src/libs/utils/settingsaccessor.cpp | |
| parent | 5951b26f1a67dd508a48788deb3a07b16220f4f3 (diff) | |
Aggregation/Utils/ExtensionSystem: Make member functions const/static
readability-make-member-function-const finds lots of member functions
that could be made const. This change just picks getter functions that
really should be const.
readability-convert-member-functions-to-static finds non-static member
functions which do not access this. This change turns most of them
into static ones, but leaves some non static to keep the class API
consistent.
readability-static-accessed-through-instance fixes the places where
the originally non-static, now static functions were called through
instance.
Change-Id: I8cf16c01f7988a7c9d073b5f8ede6a9706b94fb0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/libs/utils/settingsaccessor.cpp')
| -rw-r--r-- | src/libs/utils/settingsaccessor.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libs/utils/settingsaccessor.cpp b/src/libs/utils/settingsaccessor.cpp index 709c5c823b..ea967caeb3 100644 --- a/src/libs/utils/settingsaccessor.cpp +++ b/src/libs/utils/settingsaccessor.cpp @@ -176,7 +176,7 @@ SettingsAccessor::writeFile(const FilePath &path, const QVariantMap &data) const SettingsAccessor::ProceedInfo SettingsAccessor::reportIssues(const SettingsAccessor::Issue &issue, const FilePath &path, - QWidget *parent) const + QWidget *parent) { if (!path.exists()) return Continue; @@ -697,7 +697,7 @@ MergingSettingsAccessor::mergeSettings(const SettingsAccessor::RestoreData &main /*! * Returns true for housekeeping related keys. */ -bool MergingSettingsAccessor::isHouseKeepingKey(const QString &key) const +bool MergingSettingsAccessor::isHouseKeepingKey(const QString &key) { return key == VERSION_KEY || key == ORIGINAL_VERSION_KEY || key == SETTINGS_ID_KEY; } |