diff options
| author | hjk <hjk@qt.io> | 2019-07-24 18:40:10 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2019-07-26 09:23:48 +0000 |
| commit | 7ab6783e24c6a05a67f319817cd1bdd026a7ce43 (patch) | |
| tree | 8b56ea311d333f45f300b915c3bd25a2b77b4aef /src/libs/utils/textutils.h | |
| parent | eab0df22f98fab37585e4513de836a06e4aa05d5 (diff) | |
Standardize on int for line and column values
Recently tons of warnings show up for presumably "problematic"
singned <-> unsigned and size conversions.
The Qt side uses 'int', and that's the biggest 'integration surface'
for us, so instead of establishing some internal boundary between
signed and unsigned areas, push that boundary out of creator core code,
and use 'int' everywhere.
Because it reduces friction further, also do it in libcplusplus.
Change-Id: I84f3b79852c8029713e7ea6f133ffb9ef7030a70
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Diffstat (limited to 'src/libs/utils/textutils.h')
| -rw-r--r-- | src/libs/utils/textutils.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libs/utils/textutils.h b/src/libs/utils/textutils.h index fb0efe3f15..a86ab5d0fa 100644 --- a/src/libs/utils/textutils.h +++ b/src/libs/utils/textutils.h @@ -48,7 +48,7 @@ QTCREATOR_UTILS_EXPORT int positionInText(const QTextDocument *textDocument, int QTCREATOR_UTILS_EXPORT QString textAt(QTextCursor tc, int pos, int length); -QTCREATOR_UTILS_EXPORT QTextCursor selectAt(QTextCursor textCursor, uint line, uint column, uint length); +QTCREATOR_UTILS_EXPORT QTextCursor selectAt(QTextCursor textCursor, int line, int column, uint length); QTCREATOR_UTILS_EXPORT QTextCursor flippedCursor(const QTextCursor &cursor); |