diff options
| author | Assam Boudjelthia <assam.boudjelthia@qt.io> | 2020-06-30 16:07:09 +0300 |
|---|---|---|
| committer | Assam Boudjelthia <assam.boudjelthia@qt.io> | 2020-07-01 16:40:42 +0000 |
| commit | b085091526db64587e646a9e6762440636bdefd6 (patch) | |
| tree | 6a898f2d7b8a9bec6bbdb94a77d7d0c1b98729d0 /src/plugins/android | |
| parent | fa81549844b8f5f87cdbe9b5d9755d10cea6229f (diff) | |
Android: handle some TODO comments
Change-Id: Id1848dccc0a9b43ed77c0bd99329a0b81705a17a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Diffstat (limited to 'src/plugins/android')
| -rw-r--r-- | src/plugins/android/androiddeployqtstep.cpp | 6 | ||||
| -rw-r--r-- | src/plugins/android/androidpotentialkit.h | 2 |
2 files changed, 5 insertions, 3 deletions
diff --git a/src/plugins/android/androiddeployqtstep.cpp b/src/plugins/android/androiddeployqtstep.cpp index d5ebc69155..176c8ebf7b 100644 --- a/src/plugins/android/androiddeployqtstep.cpp +++ b/src/plugins/android/androiddeployqtstep.cpp @@ -163,8 +163,12 @@ Core::Id AndroidDeployQtStep::stepId() bool AndroidDeployQtStep::init() { QtSupport::BaseQtVersion *version = QtSupport::QtKitAspect::qtVersion(target()->kit()); - if (!version) // TODO: Add error message + if (!version) { + qCDebug(deployStepLog, + "The Qt version for kit %s is not valid.", + qPrintable(target()->kit()->displayName())); return false; + } m_androiddeployqtArgs = CommandLine(); diff --git a/src/plugins/android/androidpotentialkit.h b/src/plugins/android/androidpotentialkit.h index b7b2e6a3fd..0bc3f99f69 100644 --- a/src/plugins/android/androidpotentialkit.h +++ b/src/plugins/android/androidpotentialkit.h @@ -51,7 +51,5 @@ private: void recheck(); }; -// TODO add "Download" links to the settings page? - } } |