diff options
author | hjk <hjk@qt.io> | 2020-03-12 13:58:09 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2020-03-13 11:12:36 +0000 |
commit | 2c79196ab5d35d472fa03dd6690f6cc1b1d26b9c (patch) | |
tree | 06825e76ab01cdcd32ef1522f3a87031847a08fd /src/plugins/autotest/quick | |
parent | ea8efe58c61bce54d4f73362cef542c5fad0fb37 (diff) |
AutoTest: Tie framework settings explicitly to ITestFramework instance
This leaves no doubts regarding lifetime and type.
Change-Id: I1fdd60427a469f32236ea0fa923ec9fa308c338e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/plugins/autotest/quick')
-rw-r--r-- | src/plugins/autotest/quick/quicktestconfiguration.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/autotest/quick/quicktestconfiguration.cpp b/src/plugins/autotest/quick/quicktestconfiguration.cpp index 57d075fe7d..c2ae540b43 100644 --- a/src/plugins/autotest/quick/quicktestconfiguration.cpp +++ b/src/plugins/autotest/quick/quicktestconfiguration.cpp @@ -46,7 +46,7 @@ TestOutputReader *QuickTestConfiguration::outputReader(const QFutureInterface<Te static const Core::Id id = Core::Id(Constants::FRAMEWORK_PREFIX).withSuffix(QtTest::Constants::FRAMEWORK_NAME); TestFrameworkManager *manager = TestFrameworkManager::instance(); - auto qtSettings = qSharedPointerCast<QtTestSettings>(manager->settingsForTestFramework(id)); + auto qtSettings = dynamic_cast<QtTestSettings *>(manager->settingsForTestFramework(id)); const QtTestOutputReader::OutputMode mode = qtSettings && qtSettings->useXMLOutput ? QtTestOutputReader::XML : QtTestOutputReader::PlainText; @@ -67,8 +67,8 @@ QStringList QuickTestConfiguration::argumentsForTestRunner(QStringList *omitted) } TestFrameworkManager *manager = TestFrameworkManager::instance(); - auto qtSettings = qSharedPointerCast<QtTestSettings>(manager->settingsForTestFramework(id)); - if (qtSettings.isNull()) + auto qtSettings = dynamic_cast<QtTestSettings *>(manager->settingsForTestFramework(id)); + if (!qtSettings) return arguments; if (qtSettings->useXMLOutput) arguments << "-xml"; |